Message-ID: <1461519824.2726.78.camel@perches.com>
Subject: Re: [PATCH] checkpatch.pl: add support for checking patch from git
 repository
From: Joe Perches <joe@perches.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: changbin.du@intel.com, apw@canonical.com, linux-kernel@vger.kernel.org
Date: Sun, 24 Apr 2016 10:43:44 -0700
In-Reply-To: <20160424173012.GA29148@earth>
References: <1461494406-30000-1-git-send-email-changbin.du@intel.com>
	 <1461496965.2726.50.camel@perches.com> <20160424151052.GA12279@earth>
	 <1461514041.2726.59.camel@perches.com> <20160424173012.GA29148@earth>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1624
Lines: 33

On Sun, 2016-04-24 at 19:30 +0200, Sebastian Reichel wrote:
> On Sun, Apr 24, 2016 at 09:07:21AM -0700, Joe Perches wrote:
> > On Sun, 2016-04-24 at 17:10 +0200, Sebastian Reichel wrote:
> > > On Sun, Apr 24, 2016 at 04:22:45AM -0700, Joe Perches wrote:
> > > > On Sun, 2016-04-24 at 18:40 +0800, changbin.du@intel.com wrote:
> > > > > This patch add "-g, --git" option that tread FILE as git commits
> > > > > expression. You can specify the git commit hash ID expressions,
> > > > > then these commits from your git repository will be checked.
> > > > Why would anyone want to use checkpatch on commits already in git?
> > > It may be in some non-public development branch. Usually when I
> > > write patches I open a file, change it and commit the result or even
> > > interim result to have backups and other git features available as
> > > soon as possible. All testing is done later.
> > > 
> > > So IMHO this is a really useful feature.
> > I think it would be a more useful feature for
> > something like a git pull request rather than
> > a local git repository.
> There are basically two places, where one wants to check patches:
> 
> 1. When one creates/modifies patches
> 2. When one wants to apply patches in some tree

3. when one wants to accept patches from a pull request.

> I'm perfectly happy with checkpatch's current behaviour for
> the second task. OTOH during development I would find it useful
> if I can do something like "checkpatch --git HEAD~3..HEAD".

So you can rework the patches that are already applied?
What would you do if it showed errors/defects?

Encouraging rework seems inefficient.