Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752960AbcDXSST (ORCPT <rfc822;w@1wt.eu>);
	Sun, 24 Apr 2016 14:18:19 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:52469 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751735AbcDXSSR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 24 Apr 2016 14:18:17 -0400
Date: Sun, 24 Apr 2016 14:18:06 -0400 (EDT)
Message-Id: <20160424.141806.786009616301278103.davem@davemloft.net>
To: pramod.kumar@broadcom.com
Cc: robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com,
        yamada.masahiro@socionext.com, wens@csie.org,
        bcm-kernel-feedback-list@broadcom.com, pawel.moll@arm.com,
        mark.rutland@arm.com, arnd@arndb.de, suzuki.poulose@arm.com,
        punit.agrawal@arm.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, anup.patel@broadcom.com
Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework
From: David Miller <davem@davemloft.net>
In-Reply-To: <1461230323-27891-2-git-send-email-pramod.kumar@broadcom.com>
References: <1461230323-27891-1-git-send-email-pramod.kumar@broadcom.com>
	<1461230323-27891-2-git-send-email-pramod.kumar@broadcom.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Apr 2016 11:18:16 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 648
Lines: 21

From: Pramod Kumar <pramod.kumar@broadcom.com>
Date: Thu, 21 Apr 2016 14:48:38 +0530

> +struct shared_mdio_master *shared_mdio_alloc_master(struct device *parent,
> +						    struct device_node *node)
> +{
> +	int ret = 0;
> +	struct shared_mdio_master *master;

Always order local variable declarations in reverse christmas tree
(longest to shortest line) order.

> +static int shared_mdio_driver_probe(struct device *dev)
> +{
> +	int rc;
> +	struct shared_mdio_master *master = to_shared_mdio_master(dev);
> +	struct shared_mdio_driver *drv = to_shared_mdio_driver(dev->driver);

Likewise.

Please audit your entire submission for this issue.