Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbcDXTVI (ORCPT ); Sun, 24 Apr 2016 15:21:08 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:48205 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017AbcDXTVH (ORCPT ); Sun, 24 Apr 2016 15:21:07 -0400 Date: Sun, 24 Apr 2016 20:21:05 +0100 From: Al Viro To: Jeff Layton Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 10/15] __d_add(): don't drop/regain ->d_lock Message-ID: <20160424192105.GM25498@ZenIV.linux.org.uk> References: <20160416005232.GV25498@ZenIV.linux.org.uk> <1460768127-31822-10-git-send-email-viro@ZenIV.linux.org.uk> <1461521349.28145.2.camel@poochiereds.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461521349.28145.2.camel@poochiereds.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 342 Lines: 8 On Sun, Apr 24, 2016 at 02:09:09PM -0400, Jeff Layton wrote: > Should the above be a new __d_instantiate_locked instead of open-coding > it? Nope - it gets rehash mashed into it a few commits later. In principle we could try to fish the common helper out of it and __d_instantiate() once the dust settles, but IMO there's not much point.