Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452AbcDYD1E (ORCPT ); Sun, 24 Apr 2016 23:27:04 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54951 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbcDYD1C (ORCPT ); Sun, 24 Apr 2016 23:27:02 -0400 Date: Sun, 24 Apr 2016 23:26:56 -0400 (EDT) Message-Id: <20160424.232656.1674286215462940225.davem@davemloft.net> To: pabeni@redhat.com Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ipv4/fib: don't warn when primary address is missing if in_dev is dead From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Apr 2016 20:27:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 496 Lines: 15 From: Paolo Abeni Date: Thu, 21 Apr 2016 22:23:31 +0200 > After commit fbd40ea0180a ("ipv4: Don't do expensive useless work > during inetdev destroy.") when deleting an interface, > fib_del_ifaddr() can be executed without any primary address > present on the dead interface. > > The above is safe, but triggers some "bug: prim == NULL" warnings. > > This commit avoids warning if the in_dev is dead > > Signed-off-by: Paolo Abeni Applied, thank you.