Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbcDYEJt (ORCPT ); Mon, 25 Apr 2016 00:09:49 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:36795 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcDYEJr (ORCPT ); Mon, 25 Apr 2016 00:09:47 -0400 From: Pramod Kumar References: <1461230323-27891-1-git-send-email-pramod.kumar@broadcom.com> <1461230323-27891-2-git-send-email-pramod.kumar@broadcom.com> <20160424.141806.786009616301278103.davem@davemloft.net> In-Reply-To: <20160424.141806.786009616301278103.davem@davemloft.net> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKk4ztmgtTB5tgxlUCHBS7FyJufxwHqD0wLAPEG4cmd3LDLwA== Date: Mon, 25 Apr 2016 09:39:38 +0530 Message-ID: <5876c521a46dbb4bd1b0c22bc64ec1a5@mail.gmail.com> Subject: RE: [PATCH 1/6] bus: Add shared MDIO bus framework To: David Miller Cc: robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, yamada.masahiro@socionext.com, wens@csie.org, bcm-kernel-feedback-list@broadcom.com, pawel.moll@arm.com, mark.rutland@arm.com, arnd@arndb.de, suzuki.poulose@arm.com, punit.agrawal@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Anup Patel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 51 Hi David, Thanks for providing input over the patch. Will address the comment as described below. > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: 24 April 2016 23:48 > To: pramod.kumar@broadcom.com > Cc: robh+dt@kernel.org; catalin.marinas@arm.com; will.deacon@arm.com; > yamada.masahiro@socionext.com; wens@csie.org; bcm-kernel-feedback- > list@broadcom.com; pawel.moll@arm.com; mark.rutland@arm.com; > arnd@arndb.de; suzuki.poulose@arm.com; punit.agrawal@arm.com; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; anup.patel@broadcom.com > Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework > > From: Pramod Kumar > Date: Thu, 21 Apr 2016 14:48:38 +0530 > > > +struct shared_mdio_master *shared_mdio_alloc_master(struct device > *parent, > > + struct device_node *node) > > +{ > > + int ret = 0; > > + struct shared_mdio_master *master; > > Always order local variable declarations in reverse christmas tree (longest to > shortest line) order. > Sure. Next patch will address this. > > +static int shared_mdio_driver_probe(struct device *dev) { > > + int rc; > > + struct shared_mdio_master *master = to_shared_mdio_master(dev); > > + struct shared_mdio_driver *drv = to_shared_mdio_driver(dev->driver); > > Likewise. Sure. > Please audit your entire submission for this issue. Sure. I'll audit the entire patch set for above issue. Regards, Pramod