Message-Id: <571DE56B02000078000E5213@prv-mh.provo.novell.com>
Date: Mon, 25 Apr 2016 01:37:47 -0600
From: "Jan Beulich" <JBeulich@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: <bp@alien8.de>, <luto@amacapital.net>, <david.vrabel@citrix.com>,
        <brgerst@gmail.com>, <toshi.kani@hp.com>, <peterz@infradead.org>,
        <mingo@kernel.org>, <tglx@linutronix.de>, <akpm@linux-foundation.org>,
        <torvalds@linux-foundation.org>, <xen-devel@lists.xenproject.org>,
        <boris.ostrovsky@oracle.com>, <dvlasenk@redhat.com>,
        <vkuznets@redhat.com>, "Juergen Gross" <JGross@suse.com>,
        "Luis Rodriguez" <Mcgrof@suse.com>, <linux-kernel@vger.kernel.org>,
        <linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests
References: <57188ED802000078000E431C@prv-mh.provo.novell.com>
 <tip-103f6112f253017d7062cd74d17f4a514ed4485c@git.kernel.org>
 <571A6789.1040807@zytor.com>
In-Reply-To: <571A6789.1040807@zytor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 32

>>> On 22.04.16 at 20:03, <hpa@zytor.com> wrote:
> On 04/22/2016 02:47 AM, tip-bot for Jan Beulich wrote:
>> Commit-ID:  103f6112f253017d7062cd74d17f4a514ed4485c
>> Gitweb:     
> http://git.kernel.org/tip/103f6112f253017d7062cd74d17f4a514ed4485c 
>> Author:     Jan Beulich <JBeulich@suse.com>
>> AuthorDate: Thu, 21 Apr 2016 00:27:04 -0600
>> Committer:  Ingo Molnar <mingo@kernel.org>
>> CommitDate: Fri, 22 Apr 2016 10:05:00 +0200
>> 
>> 
>> diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h
>> index f8a29d2..e6a8613 100644
>> --- a/arch/x86/include/asm/hugetlb.h
>> +++ b/arch/x86/include/asm/hugetlb.h
>> @@ -4,6 +4,7 @@
>>  #include <asm/page.h>
>>  #include <asm-generic/hugetlb.h>
>>  
>> +#define hugepages_supported() cpu_has_pse
>>  
> 
> Please don't use the cpu_has_* macros anymore, they are going away soon.
> 
> In this case it should be static_cpu_has(X86_FEATURE_PSE).

I can certainly do that, but this
- will (mildly) harm backportability
- imo should have been requested much earlier (when the patch was
  still under discussion)

Jan