Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753794AbcDYHym (ORCPT ); Mon, 25 Apr 2016 03:54:42 -0400 Received: from www.linutronix.de ([62.245.132.108]:59527 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbcDYHyk (ORCPT ); Mon, 25 Apr 2016 03:54:40 -0400 Date: Mon, 25 Apr 2016 09:52:22 +0200 (CEST) From: Thomas Gleixner To: Jan Beulich cc: "H. Peter Anvin" , bp@alien8.de, luto@amacapital.net, david.vrabel@citrix.com, brgerst@gmail.com, toshi.kani@hp.com, peterz@infradead.org, mingo@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, dvlasenk@redhat.com, vkuznets@redhat.com, Juergen Gross , Luis Rodriguez , linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests In-Reply-To: <571DE56B02000078000E5213@prv-mh.provo.novell.com> Message-ID: References: <57188ED802000078000E431C@prv-mh.provo.novell.com> <571A6789.1040807@zytor.com> <571DE56B02000078000E5213@prv-mh.provo.novell.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 20 On Mon, 25 Apr 2016, Jan Beulich wrote: > >>> On 22.04.16 at 20:03, wrote: > >> +#define hugepages_supported() cpu_has_pse > >> > > > > Please don't use the cpu_has_* macros anymore, they are going away soon. > > > > In this case it should be static_cpu_has(X86_FEATURE_PSE). > > I can certainly do that, but this > - will (mildly) harm backportability > - imo should have been requested much earlier (when the patch was > still under discussion) It's requested now as cpu_has_* is going away. So instead of making silly arguments you should have sent a delta patch fixing this. Thanks, tglx