Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbcDYIPd (ORCPT ); Mon, 25 Apr 2016 04:15:33 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:45620 "EHLO andre.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbcDYIPa (ORCPT ); Mon, 25 Apr 2016 04:15:30 -0400 From: Geert Uytterhoeven To: "David S. Miller" , Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] [RFC] net: dsa: mv88e6xxx: Pre-initialize err in mv88e6xxx_port_bridge_join() Date: Mon, 25 Apr 2016 09:52:41 +0200 Message-Id: <1461570761-12187-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 32 drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xxx_port_bridge_join’: drivers/net/dsa/mv88e6xxx.c:2184: warning: ‘err’ may be used uninitialized in this function If netdev_notifier_changeupper_info.upper_dev is ever NULL, the bridge parameter will be NULL too, and the function will return an uninitialized value. Pre-initialize err to zero to fix this. Fixes: 207afda1b5036009 ("net: dsa: mv88e6xxx: share the same default FDB") Signed-off-by: Geert Uytterhoeven --- Can this actually happen? --- drivers/net/dsa/mv88e6xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index a2904029cccc2949..5e572b3510b9483a 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -2181,7 +2181,7 @@ int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port, struct net_device *bridge) { struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); - int i, err; + int i, err = 0; mutex_lock(&ps->smi_mutex); -- 1.9.1