Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753972AbcDYIYW (ORCPT ); Mon, 25 Apr 2016 04:24:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59264 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753663AbcDYIYU (ORCPT ); Mon, 25 Apr 2016 04:24:20 -0400 Date: Mon, 25 Apr 2016 10:24:17 +0200 From: Jiri Olsa To: kan.liang@intel.com Cc: acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/1] perf hists: clear dummy entry accumulated period Message-ID: <20160425082417.GA21990@krava> References: <1461311938-43350-1-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461311938-43350-1-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2001 Lines: 59 On Fri, Apr 22, 2016 at 12:58:58AM -0700, kan.liang@intel.com wrote: > From: Kan Liang > > The accumulated period for dummy entry should also be 0. > Otherwise, the total overhead could be overcounted. > [perf]$ perf record -e '{LLC-load-misses,cpu/instructions/}' > --call-graph=lbr ./tchain > [perf]$ perf report --stdio > # To display the perf.data header info, please use > --header/--header-only options. > # > # > # Total Lost Samples: 0 > # > # Samples: 21K of event 'anon group { LLC-load-misses, > cpu/instructions/ > }' > # Event count (approx.): 16313667937 > # > # Children Self Command Shared Object > Symbol > # ................ ................ ........... ................ > ............................ > # > 4769.98% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux] > [k] update_fast_timekeeper > 4356.18% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux] > [k] trigger_load_balance > 3181.12% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux] > [k] irq_work_tick > 1592.37% 0.00% 0.00% 0.00% tchain_edit [kernel.vmlinux] > [k] cpu_needs_another_gp > > Signed-off-by: Kan Liang > --- > > Sorry for the noise which is brought by V1. > Changes since V1: > - check he->stat_acc. Because it only be available when option children is set > > tools/perf/util/hist.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 991a351..acba139 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -2062,6 +2062,8 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists, > if (he) { > memset(&he->stat, 0, sizeof(he->stat)); > he->hists = hists; > + if (he->stat_acc) > + memset(he->stat_acc, 0, sizeof(he->stat)); we use symbol_conf.cumulate_callchain check for existance of he->stat_acc I think we should keep it here as well thanks, jirka