Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbcDYJDu (ORCPT ); Mon, 25 Apr 2016 05:03:50 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35852 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879AbcDYJDs (ORCPT ); Mon, 25 Apr 2016 05:03:48 -0400 Date: Mon, 25 Apr 2016 11:03:44 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/8] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() Message-ID: <20160425090344.GP2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461530942-22485-1-git-send-email-noralf@tronnes.org> <1461530942-22485-4-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461530942-22485-4-git-send-email-noralf@tronnes.org> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 54 On Sun, Apr 24, 2016 at 10:48:57PM +0200, Noralf Tr?nnes wrote: > Now that drm_fb_helper gets deferred io support, the > drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule > a worker that will call the (struct drm_framebuffer *)->funcs->dirty() > function. This will break this driver so use the > sys_{fillrect,copyarea,imageblit} functions directly. > > Signed-off-by: Noralf Tr?nnes For patches 2&3: Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_fb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c > index 7136e52..06f032d 100644 > --- a/drivers/gpu/drm/qxl/qxl_fb.c > +++ b/drivers/gpu/drm/qxl/qxl_fb.c > @@ -199,7 +199,7 @@ static void qxl_fb_fillrect(struct fb_info *info, > { > struct qxl_fbdev *qfbdev = info->par; > > - drm_fb_helper_sys_fillrect(info, rect); > + sys_fillrect(info, rect); > qxl_dirty_update(qfbdev, rect->dx, rect->dy, rect->width, > rect->height); > } > @@ -209,7 +209,7 @@ static void qxl_fb_copyarea(struct fb_info *info, > { > struct qxl_fbdev *qfbdev = info->par; > > - drm_fb_helper_sys_copyarea(info, area); > + sys_copyarea(info, area); > qxl_dirty_update(qfbdev, area->dx, area->dy, area->width, > area->height); > } > @@ -219,7 +219,7 @@ static void qxl_fb_imageblit(struct fb_info *info, > { > struct qxl_fbdev *qfbdev = info->par; > > - drm_fb_helper_sys_imageblit(info, image); > + sys_imageblit(info, image); > qxl_dirty_update(qfbdev, image->dx, image->dy, image->width, > image->height); > } > -- > 2.2.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch