Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754220AbcDYJES (ORCPT ); Mon, 25 Apr 2016 05:04:18 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36186 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754096AbcDYJEQ (ORCPT ); Mon, 25 Apr 2016 05:04:16 -0400 Date: Mon, 25 Apr 2016 10:04:15 +0100 From: Lee Jones To: Appana Durga Kedareswara Rao Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "srinivas.kandagatla@gmail.com" , "maxime.coquelin@st.com" , "patrice.chotard@st.com" , "vinod.koul@intel.com" , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "broonie@kernel.org" , "ludovic.barre@st.com" , Appana Durga Kedareswara Rao Subject: Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Message-ID: <20160425090415.GB20365@dell> References: <1461236675-10176-1-git-send-email-peter.griffin@linaro.org> <1461236675-10176-4-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2217 Lines: 56 On Thu, 21 Apr 2016, Appana Durga Kedareswara Rao wrote: > > -----Original Message----- > > From: dmaengine-owner@vger.kernel.org [mailto:dmaengine- > > owner@vger.kernel.org] On Behalf Of Peter Griffin > > Sent: Thursday, April 21, 2016 4:34 PM > > To: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > srinivas.kandagatla@gmail.com; maxime.coquelin@st.com; > > patrice.chotard@st.com; vinod.koul@intel.com > > Cc: peter.griffin@linaro.org; lee.jones@linaro.org; > > dmaengine@vger.kernel.org; devicetree@vger.kernel.org; arnd@arndb.de; > > broonie@kernel.org; ludovic.barre@st.com > > Subject: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA > > engine driver support What is this text? If you wish to contribute to upstream mailing lists, please fix your email client. Also, please read: Documentation/email-clients.txt > > This patch adds support for the Flexible Direct Memory Access (FDMA) core > > driver. The FDMA is a slim core CPU with a dedicated firmware. > > It is a general purpose DMA controller capable of supporting 16 > > independent DMA channels. Data moves maybe from memory to memory > > or between memory and paced latency critical real time targets and it > > is found on al STi based chipsets. > > > > Signed-off-by: Ludovic Barre > > Signed-off-by: Peter Griffin > > --- > > drivers/dma/Kconfig | 12 + > > drivers/dma/Makefile | 1 + > > drivers/dma/st_fdma.c | 967 > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 980 insertions(+) > > create mode 100644 drivers/dma/st_fdma.c [...] > > +static int st_fdma_clk_enable(struct st_fdma_dev *fdev) > > +{ > > + int i, ret; > > + > > + for (i = 0; i < CLK_MAX_NUM; i++) { > > + ret = clk_prepare_enable(fdev->clks[i]); > > + if (ret < 0) > > You should disable and unprepared the other clocks... Replying to a 1000 line email and not snipping (especially for a one single-line comment), it considered bad etiquette. Please remove all unrelated text in future. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog