Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbcDYJOg (ORCPT ); Mon, 25 Apr 2016 05:14:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:54361 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754029AbcDYJOe (ORCPT ); Mon, 25 Apr 2016 05:14:34 -0400 Date: Mon, 25 Apr 2016 11:14:20 +0200 From: Johannes Thumshirn To: axboe@fb.com Cc: keith.busch@intel.com, stable@vger.kernel.org, wenwei.tao@memblaze.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Wenbo Wang , Wenbo Wang Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq Message-ID: <20160425091420.GA20635@c203.arch.suse.de> References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2785 Lines: 86 On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt triggered nvme_process_cq may access nvmeq->q_db just > before it is updated, this could cause kernel panic. > > Signed-off-by: Wenbo Wang > Reviewed-by: Wenwei Tao > --- > drivers/nvme/host/pci.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index f5c0e26..3371c18 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -1529,9 +1529,6 @@ static struct nvme_queue *nvme_alloc_queue(struct nvme_dev *dev, int qid, > snprintf(nvmeq->irqname, sizeof(nvmeq->irqname), "nvme%dq%d", > dev->instance, qid); > spin_lock_init(&nvmeq->q_lock); > - nvmeq->cq_head = 0; > - nvmeq->cq_phase = 1; > - nvmeq->q_db = &dev->dbs[qid * 2 * dev->db_stride]; > nvmeq->q_depth = depth; > nvmeq->qid = qid; > nvmeq->cq_vector = -1; > @@ -1590,11 +1587,17 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid) > if (result < 0) > goto release_cq; > > + /* > + * Init queue door bell ioremap address before enabling irq, if not, > + * a spurious interrupt triggered nvme_process_cq may access invalid > + * address > + */ > + nvme_init_queue(nvmeq, qid); > + > result = queue_request_irq(dev, nvmeq, nvmeq->irqname); > if (result < 0) > goto release_sq; > > - nvme_init_queue(nvmeq, qid); > return result; > > release_sq: > @@ -1789,6 +1792,8 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev) > if (result) > goto free_nvmeq; > > + nvme_init_queue(nvmeq, 0); > + > nvmeq->cq_vector = 0; > result = queue_request_irq(dev, nvmeq, nvmeq->irqname); > if (result) { > @@ -3164,7 +3169,6 @@ static void nvme_probe_work(struct work_struct *work) > goto disable; > } > > - nvme_init_queue(dev->queues[0], 0); > result = nvme_alloc_admin_tags(dev); > if (result) > goto disable; > -- > 1.8.3.1 > > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme What ever happened to this patch? -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850