Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754489AbcDYKjU (ORCPT ); Mon, 25 Apr 2016 06:39:20 -0400 Received: from foss.arm.com ([217.140.101.70]:44821 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754218AbcDYKjS (ORCPT ); Mon, 25 Apr 2016 06:39:18 -0400 Subject: Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs To: "Huang, Tao" References: <1461122150-9042-1-git-send-email-jay.xu@rock-chips.com> <1461211092-26331-1-git-send-email-jay.xu@rock-chips.com> <20160421101930.GG6879@leverpostej> <5718AFB8.5070004@rock-chips.com> <20160421123018.096d4a75@arm.com> <571DE803.3010902@rock-chips.com> <571DEC3C.9070209@arm.com> Cc: Mark Rutland , devicetree@vger.kernel.org, davidriley@chromium.org, heiko@sntech.de, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, dianders@chromium.org, smbarber@chromium.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, galak@codeaurora.org, jwerner@chromium.org, linux-kernel@vger.kernel.org, Jianqun Xu , linux-arm-kernel@lists.infradead.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <571DF3CB.3030904@arm.com> Date: Mon, 25 Apr 2016 11:39:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <571DEC3C.9070209@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7212 Lines: 209 On 25/04/16 11:06, Marc Zyngier wrote: > On 25/04/16 10:48, Huang, Tao wrote: >> Hi, Marc: >> On 2016年04月21日 19:30, Marc Zyngier wrote: >>> On Thu, 21 Apr 2016 18:47:20 +0800 >>> "Huang, Tao" wrote: >>> >>>> Hi, Mark: >>>> On 2016年04月21日 18:19, Mark Rutland wrote: >>>>> On Thu, Apr 21, 2016 at 11:58:12AM +0800, Jianqun Xu wrote: >>>>>> + cpu_l0: cpu@0 { >>>>>> + device_type = "cpu"; >>>>>> + compatible = "arm,cortex-a53", "arm,armv8"; >>>>>> + reg = <0x0 0x0>; >>>>>> + enable-method = "psci"; >>>>>> + #cooling-cells = <2>; /* min followed by max */ >>>>>> + clocks = <&cru ARMCLKL>; >>>>>> + }; >>>>>> + cpu_b0: cpu@100 { >>>>>> + device_type = "cpu"; >>>>>> + compatible = "arm,cortex-a72", "arm,armv8"; >>>>>> + reg = <0x0 0x100>; >>>>>> + enable-method = "psci"; >>>>>> + #cooling-cells = <2>; /* min followed by max */ >>>>>> + clocks = <&cru ARMCLKB>; >>>>>> + }; >>>>>> + >>>>>> + arm-pmu { >>>>>> + compatible = "arm,armv8-pmuv3"; >>>>>> + interrupts = ; >>>>>> + }; >>>>> This is wrong, and must go. There should be a separate node for the PMU >>>>> of each microarchitecture, with the appropriate compatible string to >>>>> represent that (see the juno dts). >>>> You are right. The first version we wrote is: >>>> pmu_a53 { >>>> compatible = "arm,cortex-a53-pmu"; >>>> interrupts = ; >>>> interrupt-affinity = <&cpu_l0>, >>>> <&cpu_l1>, >>>> <&cpu_l2>, >>>> <&cpu_l3>; >>>> }; >>>> >>>> pmu_a72 { >>>> compatible = "arm,cortex-a72-pmu"; >>>> interrupts = ; >>>> interrupt-affinity = <&cpu_b0>, >>>> <&cpu_b1>; >>>> }; >>>> but unfortunately, the arm pmu driver do not support PPI in two cluster >>>> well, >>>> so we have to replace with this implementation. >>>>> In this case things are messier as the same PPI number is being used >>>>> across clusters. Marc (Cc'd) has been working on PPI partitions, which >>>>> should allow us to support that. >>>> Great! So what we can do right now? Wait this feature, and delete >>>> arm-pmu node? >>> I'd rather you have a look at the patches, test them with your HW, >>> and comment on what doesn't work! >>> >>> You can find the patches over there: >>> >>> https://lkml.org/lkml/2016/4/11/182 >>> >>> and on the following branch: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git >>> irq/percpu-partition >> >> I tested these patches. Because our kernel is based on v4.4, so I back >> port most changes about >> include/linux/irqdomain.h >> kernel/irq/irqdomain.c >> drivers/irqchip/irq-gic-v3.c >> and change rk3399.dtsi base on your arm,gic-v3.txt: >> >> gic: interrupt-controller@fee00000 { >> compatible = "arm,gic-v3"; >> - #interrupt-cells = <3>; >> + #interrupt-cells = <4>; >> #address-cells = <2>; >> #size-cells = <2>; >> ... >> + >> + ppi-partitions { >> + part0: interrupt-partition-0 { >> + affinity = <&cpu_l0 &cpu_l1 &cpu_l2 &cpu_l3>; >> + }; >> + >> + part1: interrupt-partition-1 { >> + affinity = <&cpu_b0 &cpu_b1>; >> + }; >> + }; >> >> and change every interrupts from three cells to four cells, such as >> saradc: saradc@ff100000 { >> compatible = "rockchip,rk3399-saradc"; >> reg = <0x0 0xff100000 0x0 0x100>; >> - interrupts = ; >> + interrupts = ; >> #io-channel-cells = <1>; >> clocks = <&cru SCLK_SARADC>, <&cru PCLK_SARADC>; >> clock-names = "saradc", "apb_pclk"; >> >> and pmu define as: >> pmu_a53 { >> compatible = "arm,cortex-a53-pmu"; >> interrupts = ; >> interrupt-affinity = <&cpu_l0>, >> <&cpu_l1>, >> <&cpu_l2>, >> <&cpu_l3>; >> }; >> >> pmu_a72 { >> compatible = "arm,cortex-a72-pmu", "arm,cortex-a57-pmu"; >> interrupts = ; >> interrupt-affinity = <&cpu_b0>, >> <&cpu_b1>; >> }; >> >> It can boot. And I test with Android simpleperf stat and perf top, it works! >> So these patches work on RK3399. > > Good, thanks for testing. > >> But as I mentioned, we must change every interrupt in dts, do you think >> this is acceptable? > > I can't see why not. > >>> >>> Of course, you'll have to hack a bit in the PMU code to make it >>> understand per-PMU affinity together with percpu interrupts, but it >>> wouldn't be fun if there was nothing to do... >> I don't change drivers/perf/arm_pmu.c, it just work. > > Having had a look with Mark, it may work, but it is rather unsafe. I may > have a go at it, but I'm going to have to rely on you to test it (or you > can send me a board ;-). I came up with the following (untested) patch. Please let me know if this works for you. Thanks, M. >From b88c08bb689d3fe40c46788453a07ba22dae9220 Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Mon, 25 Apr 2016 11:23:54 +0100 Subject: [PATCH] drivers/perf: arm-pmu: Handle per-interrupt affinity mask On a big-little system, PMUs can be wired to CPUs using per CPU interrups (PPI). In this case, it is important to make sure that the enable/disable do happen on the right set of CPUs. Do this by querying the corresponding cpumask on the corresponding paths Signed-off-by: Marc Zyngier --- drivers/perf/arm_pmu.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index f700908..3de5e1c 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -603,7 +603,11 @@ static void cpu_pmu_free_irq(struct arm_pmu *cpu_pmu) irq = platform_get_irq(pmu_device, 0); if (irq >= 0 && irq_is_percpu(irq)) { - on_each_cpu(cpu_pmu_disable_percpu_irq, &irq, 1); + struct cpumask ppi_cpumask; + + irq_get_percpu_devid_partition(irq, &ppi_cpumask); + on_each_cpu_mask(&ppi_cpumask, cpu_pmu_disable_percpu_irq, + &irq, 1); free_percpu_irq(irq, &hw_events->percpu_pmu); } else { for (i = 0; i < irqs; ++i) { @@ -638,6 +642,8 @@ static int cpu_pmu_request_irq(struct arm_pmu *cpu_pmu, irq_handler_t handler) irq = platform_get_irq(pmu_device, 0); if (irq >= 0 && irq_is_percpu(irq)) { + struct cpumask ppi_cpumask; + err = request_percpu_irq(irq, handler, "arm-pmu", &hw_events->percpu_pmu); if (err) { @@ -645,7 +651,10 @@ static int cpu_pmu_request_irq(struct arm_pmu *cpu_pmu, irq_handler_t handler) irq); return err; } - on_each_cpu(cpu_pmu_enable_percpu_irq, &irq, 1); + + irq_get_percpu_devid_partition(irq, &ppi_cpumask); + on_each_cpu_mask(&ppi_cpumask, cpu_pmu_enable_percpu_irq, + &irq, 1); } else { for (i = 0; i < irqs; ++i) { int cpu = i; -- 2.1.4 -- Jazz is not dead. It just smells funny...