Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214AbcDYKvS (ORCPT ); Mon, 25 Apr 2016 06:51:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47365 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562AbcDYKvQ (ORCPT ); Mon, 25 Apr 2016 06:51:16 -0400 From: Vitaly Kuznetsov To: Dexuan Cui Cc: "devel\@linuxdriverproject.org" , "linux-kernel\@vger.kernel.org" , "KY Srinivasan" , Haiyang Zhang Subject: Re: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID References: <1461342038-25725-1-git-send-email-vkuznets@redhat.com> Date: Mon, 25 Apr 2016 12:51:12 +0200 In-Reply-To: (Dexuan Cui's message of "Sat, 23 Apr 2016 01:21:42 +0000") Message-ID: <87potex8pr.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 46 Dexuan Cui writes: >> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com] >> Sent: Saturday, April 23, 2016 0:21 >> To: devel@linuxdriverproject.org >> Cc: linux-kernel@vger.kernel.org; KY Srinivasan ; Haiyang >> Zhang ; Dexuan Cui >> Subject: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID >> >> lsvmbus keeps its own copy of all VMBus UUIDs, add PCIe pass-through >> device there to not report 'Unknown' for such devices. >> >> Signed-off-by: Vitaly Kuznetsov >> --- >> tools/hv/lsvmbus | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus >> index 162a378..e223284 100644 >> --- a/tools/hv/lsvmbus >> +++ b/tools/hv/lsvmbus >> @@ -35,6 +35,7 @@ vmbus_dev_dict = { >> '{ba6163d9-04a1-4d29-b605-72e2ffb1dc7f}' : 'Synthetic SCSI Controller', >> '{2f9bcc4a-0069-4af3-b76b-6fd0be528cda}' : 'Synthetic fiber channel >> adapter', >> '{8c2eaf3d-32a7-4b09-ab99-bd1f1c86b501}' : 'Synthetic RDMA adapter', >> + '{44c4f61d-4444-4400-9d52-802e27ede19f}' : 'PCI Express pass-through', > Please use TAB rather than 8 space chars here. :-) > Oops, I was pretty sure checkpatch.pl catches such issues but apparently it doesn't work for python scripts. And my text editor failed me as well) >> '{276aacf4-ac15-426c-98dd-7521ad3f01fe}' : '[Reserved system device]', >> '{f8e65716-3cb3-4a06-9a60-1889c5cccab5}' : '[Reserved system >> device]', >> '{3375baf4-9e15-4b30-b765-67acb10d607b}' : '[Reserved system >> device]', >> -- > > Looks good to me except for the space/TAB issue. Sure, will send v2. -- Vitaly