Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754544AbcDYK7c (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 06:59:32 -0400
Received: from mail-io0-f195.google.com ([209.85.223.195]:36513 "EHLO
	mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754483AbcDYK7a (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 06:59:30 -0400
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier
From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Tony Lindgren <tony@atomide.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Lee Jones <lee.jones@linaro.org>, Roland Stigge <stigge@antcom.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Russell King <linux@arm.linux.org.uk>,
        Alexander Shiyan <shc_work@mail.ru>, Kevin Hilman <khilman@kernel.org>,
        Viresh Kumar <vireshk@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        spear-devel@list.st.com, Ray Jui <rjui@broadcom.com>,
        Rajendra Nayak <rnayak@ti.com>, Sekhar Nori <nsekhar@ti.com>,
        Krzysztof Halasa <khalasa@piap.pl>,
        Gregory Fong <gregory.0xf0@gmail.com>, linux-omap@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, Paul Walmsley <paul@pwsan.com>,
        Scott Branden <sbranden@broadcom.com>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
        linux-kernel@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>, vz@mleia.com
In-Reply-To: <20160425095715.GA2366@piout.net>
References: <1461577678-29517-1-git-send-email-eric.engestrom@imgtec.com>
	 <1461577678-29517-4-git-send-email-eric.engestrom@imgtec.com>
	 <20160425095715.GA2366@piout.net>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 25 Apr 2016 06:59:14 -0400
Message-ID: <1461581954.24648.16.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1808
Lines: 51

Hi Eric,

On Mon, 2016-04-25 at 11:57 +0200, Alexandre Belloni wrote:
> Hi,
> 
> this requires a commit message.
> 
> Also, you should think about separating those changes in multiple patches
> to ease inclusion in the kernel.
> 
> On 25/04/2016 at 10:47:57 +0100, Eric Engestrom wrote :
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  arch/arm/mach-at91/pm.c                 | 2 +-
> >  arch/arm/mach-bcm/bcm_kona_smc.c        | 2 +-
> >  arch/arm/mach-clps711x/board-autcpu12.c | 2 +-
> >  arch/arm/mach-cns3xxx/core.c            | 2 +-
> >  arch/arm/mach-davinci/da8xx-dt.c        | 2 +-
> >  arch/arm/mach-lpc32xx/phy3250.c         | 2 +-
> >  arch/arm/mach-mxs/mach-mxs.c            | 2 +-
> >  arch/arm/mach-omap2/prm_common.c        | 2 +-
> >  arch/arm/mach-omap2/vc.c                | 2 +-
> >  arch/arm/mach-spear/time.c              | 2 +-
> >  10 files changed, 10 insertions(+), 10 deletions(-)
> > 
...

> > diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
> > index b2f9e22..1ae7230 100644
> > --- a/arch/arm/mach-lpc32xx/phy3250.c
> > +++ b/arch/arm/mach-lpc32xx/phy3250.c
> > @@ -159,7 +159,7 @@ static struct lpc32xx_mlc_platform_data lpc32xx_mlc_data = {
> >  	.dma_filter = pl08x_filter_id,
> >  };
> >  
> > -static const struct of_dev_auxdata const lpc32xx_auxdata_lookup[] __initconst = {
> > +static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
> >  	OF_DEV_AUXDATA("arm,pl022", 0x20084000, "dev:ssp0", NULL),
> >  	OF_DEV_AUXDATA("arm,pl022", 0x2008C000, "dev:ssp1", NULL),
> >  	OF_DEV_AUXDATA("arm,pl110", 0x31040000, "dev:clcd", &lpc32xx_clcd_data),

A patch was already submitted for the LPC32xx:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/493312/

...
> > -- 
> > 2.7.4
> > 
> 
Sylvain