Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754582AbcDYL3t (ORCPT ); Mon, 25 Apr 2016 07:29:49 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:9514 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754344AbcDYL3r (ORCPT ); Mon, 25 Apr 2016 07:29:47 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 25 Apr 2016 04:29:22 -0700 Subject: Re: [PATCH v4] dmaengine: tegra-apb: proper default init of channel slave_id To: Shardar Shariff Md , , , , , , , , , References: <1461404160-19612-1-git-send-email-smohammed@nvidia.com> X-Nvconfidentiality: public From: Jon Hunter Message-ID: <571DFFA4.1040701@nvidia.com> Date: Mon, 25 Apr 2016 12:29:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461404160-19612-1-git-send-email-smohammed@nvidia.com> X-Originating-IP: [10.21.132.106] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 524 Lines: 17 On 23/04/16 10:36, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > > Signed-off-by: Shardar Shariff Md Thanks for the update. I have tested this on Tegra124 using the serial port with DMA. Reviewed-by: Jon Hunter Tested-by: Jon Hunter Cheers Jon