Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbcDYMjm (ORCPT ); Mon, 25 Apr 2016 08:39:42 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:36801 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324AbcDYMjk (ORCPT ); Mon, 25 Apr 2016 08:39:40 -0400 X-IronPort-AV: E=Sophos;i="5.24,532,1454976000"; d="scan'208";a="356201007" Subject: Re: [Xen-devel] [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests To: Thomas Gleixner , Jan Beulich References: <57188ED802000078000E431C@prv-mh.provo.novell.com> <571A6789.1040807@zytor.com> <571DE56B02000078000E5213@prv-mh.provo.novell.com> CC: , Juergen Gross , , , , , Luis Rodriguez , , , , , , , "H. Peter Anvin" , , , , From: David Vrabel Message-ID: <571E1006.8080102@citrix.com> Date: Mon, 25 Apr 2016 13:39:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 25 On 25/04/16 08:52, Thomas Gleixner wrote: > On Mon, 25 Apr 2016, Jan Beulich wrote: >>>>> On 22.04.16 at 20:03, wrote: >>>> +#define hugepages_supported() cpu_has_pse >>>> >>> >>> Please don't use the cpu_has_* macros anymore, they are going away soon. >>> >>> In this case it should be static_cpu_has(X86_FEATURE_PSE). >> >> I can certainly do that, but this >> - will (mildly) harm backportability >> - imo should have been requested much earlier (when the patch was >> still under discussion) > > It's requested now as cpu_has_* is going away. So instead of making silly > arguments you should have sent a delta patch fixing this. Ingo fixed this up in the x86/asm branch[1] so I assumed this patch didn't need updating. David [1] https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/asm&id=b2eafe890d4a09bfa63ab31ff018d7d6bb8cfefc