Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932555AbcDYM4L (ORCPT ); Mon, 25 Apr 2016 08:56:11 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35838 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932496AbcDYM4J (ORCPT ); Mon, 25 Apr 2016 08:56:09 -0400 Date: Mon, 25 Apr 2016 18:26:05 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, nm@ti.com, Andrew Lunn , linaro-kernel@lists.linaro.org, Jason Cooper , linux-pm@vger.kernel.org, sboyd@codeaurora.org, Rafael Wysocki , linux-kernel@vger.kernel.org, Gregory Clement , thomas.petazzoni@free-electrons.com, Sebastian Hesselbarth Subject: Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Message-ID: <20160425125605.GG6104@vireshk-i7> References: <7576455.rVXD0283Nr@wuerfel> <20160425030041.GF22726@vireshk-i7> <6893237.FoNPbfW3DC@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6893237.FoNPbfW3DC@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 28 On 25-04-16, 14:53, Arnd Bergmann wrote: > On Monday 25 April 2016 08:30:41 Viresh Kumar wrote: > I realize that the ordering is fixed through the way that the kernel > is linked, my worry is more about someone changing the code in some > way because it's not obvious from reading the code that the > dependency exists. If either the armada_xp_pmsu_cpufreq_init() > initcall gets changed so it does not always get called, or the > cpufreq_dt_platdev_init() initcall gets changed so it comes a little > earlier, things will break. cpufreq-dt will just error out in that case, because it wouldn't find any OPPs registered to the OPP-core. It *shouldn't* crash and if it does, then we have a problem to fix. > > The other thing that can happen is that armada_xp_pmsu_cpufreq_init() > > call can fail. In that case, most of the times cpufreq-dt ->init() > > will fail as well, so even that is fine for me. > > > > And, so I think we can keep this patch as is. > > What are the downsides of moving armada_xp_pmsu_cpufreq_init() > into drivers/cpufreq? More special code :) -- viresh