Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932606AbcDYNQt (ORCPT ); Mon, 25 Apr 2016 09:16:49 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:45267 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932166AbcDYNQr (ORCPT ); Mon, 25 Apr 2016 09:16:47 -0400 Date: Mon, 25 Apr 2016 15:16:40 +0200 From: Andrew Lunn To: Timur Tabi Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, Shanker Donthineni , Greg Kroah-Hartman , vikrams@codeaurora.org, cov@codeaurora.org, gavidov@codeaurora.org, Rob Herring , bjorn.andersson@linaro.org, Mark Langsdorf , Jon Masters , Andy Gross , "David S. Miller" Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Message-ID: <20160425131640.GD6575@lunn.ch> References: <1460570393-19838-1-git-send-email-timur@codeaurora.org> <570EC541.6080603@gmail.com> <570FFB6B.5060305@codeaurora.org> <57100962.40404@gmail.com> <571915F5.5070504@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571915F5.5070504@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 39 > Does the compatible property of the phy node (for the external phy) > need to list the actual external phy? That is, should it look like > this: > > phy0: ethernet-phy@0 { > compatible = "qcom,fsm9900-emac-phy"; > reg = <0>; > } > > or this: > > phy0: ethernet-phy@0 { > compatible = "athr,whatever-phy"; > reg = <0>; > } > Documentation/devicetree/bindings/net/phy.txt says: Optional Properties: - compatible: Compatible list, may contain "ethernet-phy-ieee802.3-c22" or "ethernet-phy-ieee802.3-c45" for PHYs that implement IEEE802.3 clause 22 or IEEE802.3 clause 45 specifications. If neither of these are specified, the default is to assume clause 22. If the phy's identifier is known then the list may contain an entry of the form: "ethernet-phy-idAAAA.BBBB" where AAAA - The value of the 16 bit Phy Identifier 1 register as 4 hex digits. This is the chip vendor OUI bits 3:18 BBBB - The value of the 16 bit Phy Identifier 2 register as 4 hex digits. This is the chip vendor OUI bits 19:24, followed by 10 bits of a vendor specific ID. The compatible list should not contain other values than those listed here. Andrew