Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932774AbcDYNr4 (ORCPT ); Mon, 25 Apr 2016 09:47:56 -0400 Received: from mail.skyhub.de ([78.46.96.112]:35362 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932485AbcDYNry (ORCPT ); Mon, 25 Apr 2016 09:47:54 -0400 Date: Mon, 25 Apr 2016 15:47:49 +0200 From: Borislav Petkov To: Boris Ostrovsky Cc: "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com, mcgrof@suse.com Subject: Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest Message-ID: <20160425134749.GB28454@pd.tnic> References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-3-git-send-email-boris.ostrovsky@oracle.com> <20160424202314.GA3973@pd.tnic> <571E19D7.1080301@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <571E19D7.1080301@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 20 On Mon, Apr 25, 2016 at 09:21:27AM -0400, Boris Ostrovsky wrote: > I was following Documentation/x86/boot.txt (plus comments in code preceding > those two routines) which I considered to be the API. > > We are supposed to come to startup_32 with paging off and %esi pointing to > boot_params. For 64-bit paging is on, %rsi points to zero-page. So the entry points which are ABI and the ones I believe you're talking about are in arch/x86/boot/compressed/head_64.S. But you have all this stuff laid out in arch/x86/xen/ and I don't see you using the entry points in boot/compressed/. It looks more to me that you're using the ones in arch/x86/kernel/head_{32,64}.S after decompression. Or am I missing something? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.