Subject: Re: [PATCH 3/5] ARM: dts: introduce MPS2 AN385/AN386
To: Vladimir Murzin <vladimir.murzin@arm.com>
References: <1461574157-23580-1-git-send-email-vladimir.murzin@arm.com>
 <571DE21A.5010502@suse.com> <571DEE47.3090208@arm.com>
 <5670114.66Ur0mq4Xc@wuerfel> <571E0785.1060200@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Sudeep Holla <sudeep.holla@arm.com>,
        Matthias Brugger <mbrugger@suse.com>, lorenzo.pieralisi@arm.com,
        linux@arm.linux.org.uk, liviu.dudau@arm.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <571E2110.2070705@arm.com>
Date: Mon, 25 Apr 2016 14:52:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <571E0785.1060200@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1209
Lines: 43


On 25/04/16 13:03, Vladimir Murzin wrote:
> On 25/04/16 12:32, Arnd Bergmann wrote:
>> On Monday 25 April 2016 11:15:35 Vladimir Murzin wrote:
>>>>> +
>>>>> +#include "mps2.dtsi"
>>>>> +
>>>>> +/ {
>>>>> +    model = "ARM MPS2 Application Note 385/386";
>>>>> +    compatible = "arm,mps2";
>>>>> +
>>>>> +    aliases {
>>>>> +        serial0 = &uart0;
>>>>> +    };
>>>>> +
>>>>> +    chosen {
>>>>> +        bootargs = "rdinit=/sbin/init earlycon";
>>>>
>>>> The rootfs should be independent from the board.
>>>> In my opinion, this type of bootargs should not be part of the DTS.
>>>
>>> I have no strong opinion on this, but quick grep shows plenty places
>>> where the same happens, and even [1] has rootfs specific option as an
>>> example. So if there is no strong call to remove rdinit from bootargs,
>>> I'd prefer to keep it as it makes testing easier for me.
>>>
>>> [1] Documentation/devicetree/booting-without-of.txt
>>>
>>
>> I think "rdinit=/sbin/init" is redundant, that is what we try running
>> anyway, so I don't see any downside in removing it.
>
> Fair point.
>
> @Sudeep could you fixup it locally or I need to respin?
>

Done and pushed, will send PR later today.

-- 
Regards,
Sudeep