Subject: Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest
To: Borislav Petkov <bp@alien8.de>
References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com>
 <1454341137-14110-3-git-send-email-boris.ostrovsky@oracle.com>
 <20160424202314.GA3973@pd.tnic> <571E19D7.1080301@oracle.com>
 <20160425134749.GB28454@pd.tnic>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, david.vrabel@citrix.com,
        konrad.wilk@oracle.com, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, roger.pau@citrix.com, mcgrof@suse.com
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <571E219D.2090308@oracle.com>
Date: Mon, 25 Apr 2016 09:54:37 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20160425134749.GB28454@pd.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 19

On 04/25/2016 09:47 AM, Borislav Petkov wrote:
> On Mon, Apr 25, 2016 at 09:21:27AM -0400, Boris Ostrovsky wrote:
>> I was following  Documentation/x86/boot.txt (plus comments in code preceding
>> those two routines) which I considered to be the API.
>>
>> We are supposed to come to startup_32 with paging off and %esi pointing to
>> boot_params. For 64-bit paging is on, %rsi points to zero-page.
> So the entry points which are ABI and the ones I believe you're talking
> about are in arch/x86/boot/compressed/head_64.S. But you have all this
> stuff laid out in arch/x86/xen/ and I don't see you using the entry
> points in boot/compressed/. It looks more to me that you're using the
> ones in arch/x86/kernel/head_{32,64}.S after decompression.

Yes, those. We don't do anything in arch/x86/boot/compressed, hypervisor 
loads vmlinuX at entry point specified by XEN_ELFNOTE_PHYS32_ENTRY 
(which is hvmlite_start_xen).


-boris