Date: Mon, 25 Apr 2016 10:12:16 -0400 (EDT)
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Eric Engestrom <eric.engestrom@imgtec.com>
cc: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Tony Lindgren <tony@atomide.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Lee Jones <lee.jones@linaro.org>, Roland Stigge <stigge@antcom.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Russell King <linux@arm.linux.org.uk>,
        Alexander Shiyan <shc_work@mail.ru>, Kevin Hilman <khilman@kernel.org>,
        Viresh Kumar <vireshk@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        spear-devel@list.st.com, Ray Jui <rjui@broadcom.com>,
        Rajendra Nayak <rnayak@ti.com>, Sekhar Nori <nsekhar@ti.com>,
        Krzysztof Halasa <khalasa@piap.pl>,
        Gregory Fong <gregory.0xf0@gmail.com>, linux-omap@vger.kernel.org,
        Paul Walmsley <paul@pwsan.com>, Scott Branden <sbranden@broadcom.com>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
        linux-kernel@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 4/4] ARM: remove duplicate const qualifier
In-Reply-To: <20160425125809.GP32731@imgtec.com>
Message-ID: <alpine.LFD.2.20.1604250953200.5091@knanqh.ubzr>
References: <1461577678-29517-1-git-send-email-eric.engestrom@imgtec.com> <20160425095715.GA2366@piout.net> <20160425103911.GO32731@imgtec.com> <4641918.pNBP5iAK01@wuerfel> <20160425125809.GP32731@imgtec.com>
User-Agent: Alpine 2.20 (LFD 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1093
Lines: 28

On Mon, 25 Apr 2016, Eric Engestrom wrote:

> On Mon, Apr 25, 2016 at 01:38:18PM +0200, Arnd Bergmann wrote:
> > Maybe say you you found it (llvm, sparse, coccinelle?), and why this
> > is causing a problem for anyone. If it's just unnecessary but not
> > harmful, I'd probably ignore the patch.
> 
> $ grep -rE '(^|\W)const(\s+\w+)+\s+const\s'
> 
> I just happened to notice some unnecessary const in our internal code,
> so I grep'ed for it in a couple big OSS projects to see how common it
> was. Since I found only a few, I decided to remove them, but like I said
> it just gets ignored by all the compilers I know, so there's absolutely
> no harm in leaving this dead code around.

Beware.

I added many of those exactly because gcc did not ignore them when 
compiling with LTO where the lack of a const qualifier to qualify the 
actual array content, and not only the reference to that content, 
generated build errors due to section mismatches from the __initconst 
annotation.

So this is a NAK from me unless you may confirm that LTO builds are 
unaffected by your changes.


Nicolas