Date: Mon, 25 Apr 2016 16:31:33 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Wanpeng Li <kernellwp@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org, Wanpeng Li <wanpeng.li@hotmail.com>,
        Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3] sched/cpufreq: optimize cpufreq update kicker to
 avoid update multiple times
Message-ID: <20160425143133.GK3430@twins.programming.kicks-ass.net>
References: <1461316044-9520-1-git-send-email-wanpeng.li@hotmail.com>
 <571A1368.9060409@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <571A1368.9060409@intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 885
Lines: 26

On Fri, Apr 22, 2016 at 02:04:56PM +0200, Rafael J. Wysocki wrote:
> [Added linux-pm to the CC - can you please do so for PM-related patches in
> the future?]
> 
> On 4/22/2016 11:07 AM, Wanpeng Li wrote:
> >From: Wanpeng Li <wanpeng.li@hotmail.com>
> >
> >Sometimes delta_exec is 0 due to update_curr() is called multiple times,
> >this is captured by:
> >
> >	u64 delta_exec = rq_clock_task(rq) - curr->se.exec_start;
> >
> >This patch optimizes the cpufreq update kicker by bailing out when nothing
> >changed, it will benefit the upcoming schedutil, since otherwise it will
> >(over)react to the special util/max combination.
> >
> >Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> The changelog looks better now, thanks!
> 
> Peter, do I think correctly that you're going to take care of this one?  Or
> do you want me to take it?

YEah, looks fine. I'll take it.

Thanks!