Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932720AbcDYPBS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 11:01:18 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:38835 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932459AbcDYPBR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 11:01:17 -0400
MIME-Version: 1.0
In-Reply-To: <571DC72F.3030503@suse.cz>
References: <5715FEFD.9010001@gmail.com>
	<20160421162210.f4a50b74bc6ce886ac8c8e4e@linux-foundation.org>
	<571DC72F.3030503@suse.cz>
Date: Mon, 25 Apr 2016 17:01:15 +0200
Message-ID: <CAMJBoFN7ZFnz9-mG4Vn=Sd-p-bCdnC_H30br=JANMsoWM5Eayw@mail.gmail.com>
Subject: Re: [PATCH v2] z3fold: the 3-fold allocator for compressed pages
From: Vitaly Wool <vitalywool@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Seth Jennings <sjenning@redhat.com>, Dan Streetman <ddstreet@ieee.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1158
Lines: 26

On Mon, Apr 25, 2016 at 9:28 AM, Vlastimil Babka <vbabka@suse.cz> wrote:
> On 04/22/2016 01:22 AM, Andrew Morton wrote:
<snip>
>>
>> So...  why don't we just replace zbud with z3fold?  (Update the changelog
>> to answer this rather obvious question, please!)
>
>
> There was discussion between Seth and Vitaly on v1. Without me knowing the
> details myself, it looked like Seth's objections were addressed, but then
> the thread died. I think there should first be a more clear answer from Seth
> whether z3fold really looks like a clear win (i.e. not workload-dependent)
> over zbud, in which case zbud could be extended?

I have tried to address this question in the changelog for v3 which came out
today. Basically I'd like to play on the safe side and have z3fold
co-existing with
zbud for a while, since zbud is a simple and proven solution which has less
object code and can work without ZPOOL. The original zbud implementation
doesn't use struct page's fields in any way, which z3fold can't get
away without.

As a matter of fact, I don't think there's much of the similar code left between
zbud and z3fold, other than the generic structure.

~vitaly