Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932811AbcDYP3A (ORCPT ); Mon, 25 Apr 2016 11:29:00 -0400 Received: from mail-by2on0092.outbound.protection.outlook.com ([207.46.100.92]:34496 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932511AbcDYP25 (ORCPT ); Mon, 25 Apr 2016 11:28:57 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-996e898000000be7-a7-571e37437bb2 Subject: Re: [Drbd-dev] [PATCH 04/30] drbd: Implement handling of thinly provisioned storage on resync target nodes To: Philipp Reisner , Jens Axboe , "linux-kernel@vger.kernel.org" References: <1461586077-11581-1-git-send-email-philipp.reisner@linbit.com> <1461586077-11581-5-git-send-email-philipp.reisner@linbit.com> CC: "drbd-dev@lists.linbit.com" From: Bart Van Assche Message-ID: <571E37AD.1050607@sandisk.com> Date: Mon, 25 Apr 2016 08:28:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1461586077-11581-5-git-send-email-philipp.reisner@linbit.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPLMWRmVeSWpSXmKPExsWyRoxnka6zuVy4QespAYv/e46xWTy8uoLF 4vKuOWwWL2c+ZnJg8ZjY/I7d4+mVI0weLQ/a2Dw+b5ILYInisklJzcksSy3St0vgymh6dZyp YB1zxdk1U9kaGK8xdTFyckgImEhcPDSLvYuRi0NIYC6TxIkZt5ghnB2MEhvO/WOGqTrWPJMN xBYSWMooceE5I4gtLFAqcWDDIiaQBhGBHkaJGa+nM0J0dzNK9Jx6yQJSxSxgLbGjcSU7iM0m YCTx7f1MsDivgJZE65QVYBtYBFQlNv78ABYXFYiQWL3uGjNEjaDEyZlPgOIcHJwC3hI/3rpC jLSQmDn/PCOELS+x/e0csKslBDaxSmzr/cAEcam6xMkl85kmMArPQjJqFpL+WUj6FzAyr2IU y83MKc5NTy0wNNUrTsxLySzO1kvOz93ECImGzB2Md594H2IU4GBU4uH9wCIbLsSaWFZcmXuI UYKDWUmEV8lELlyINyWxsiq1KD++qDQntfgQozQHi5I4r9u9L2FCAumJJanZqakFqUUwWSYO TqkGxoNT5lruvnfxi76FtFmlwownSxe9eXQ4qqd6+efsMIN/32TY/83YfVDDPMD1WnTQs/su /zZXJ7GlvH4TyzA55e1M64nO4WZ/BU41PRer279u+/sHSjEZXQsPzos4uuXxG1HBV2y8l/yV o4T6TpsyaV9OrjFl3Xm4TP7Jqv2v2t+/1pZKe7Ju1wwlluKMREMt5qLiRAA4XtlaggIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCJMWRmVeSWpSXmKPExsXCtZEjRXetuVy4wZ6FfBb/9xxjs3h4dQWL xeVdc9gsXs58zOTA4jGx+R27x9MrR5g8Wh60sXl83iQXwBLFZZOSmpNZllqkb5fAldH06jhT wTrmirNrprI1MF5j6mLk5JAQMJE41jyTrYuRi0NIYDGjxJPFr9hAEsICpRIHNixiAkmICPQw Siy6tZwdoqqbUaLn1EuWLkYODmYBa4kPC0pAGtgEjCS+vZ/JAmLzCmhJtE5ZwQxiswioSmz8 +QEsLioQIbF63TVmiBpBiZMzn4CN4RTwlvjx1hUkzCxgJjFv80NmCFteYvvbOcwTGPlmIemY haRsFpKyBYzMqxjFcjNzinPTMwsMjfSKE/NSMouz9ZLzczcxgsORM2oH4/WJ5ocYmTg4pRoY 5z+ZsiC563T5RJlpN9IO+bV1zqzMX7T0WjOLhi5fbPwbxeo5ItPSin8VKmz3+zyz59Ebxr1R qX0xpl9NN92wWvP5UpHNhdvB58899rj2fObKRzOmcWwLkT1wXYLritCeyetnPDH/qPz4R97E olcJ8jfjNpf8mR52ZEGF7pwPvAos7n4/EufyTFFiKc5INNRiLipOBAD3CLEX9wEAAA== X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(377454003)(189002)(24454002)(65806001)(65956001)(2906002)(11100500001)(92566002)(64126003)(4326007)(586003)(1220700001)(1096002)(106466001)(5003600100002)(86362001)(189998001)(5001770100001)(47776003)(2270400002)(80316001)(23676002)(33656002)(2950100001)(76176999)(83506001)(36756003)(6806005)(5008740100001)(53416004)(87266999)(54356999)(65816999)(50986999)(230700001)(2501003)(87936001)(81166005)(77096005);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0201MB1928;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD028;1:Ian4WTomcrTedKYOgMjdhg4fasfNxovUJy2OnuwW4bpsHVtKr8BmZbKGG5z1lGJh5hgzuURr8K45dqPyUTNvnmi5i9xDSLdBERG7JYqtrlC1Q7zLmLNi81o1PNE29ROGOJc0GuUwZ7AalLpZToL/aeQmoL0iR3FDILF0TnNEArmJTfcc97LRsVnXMfjsXxtzEpZLnwiKj2v0JRcPmIjUAew1USDSkUBTVGm/8zB91x7/Fg2j9DalLiY/1hOiddPLR5LlELHLMq0dXYXxVoMEwl2RPFkOV/AMC93s8+UXvQT2lz3cvbLtZwa33E1JFmldIgJhD9SG2l9JVwcL24v+8qPxoklX/tqmAjhWCwC0ym4UHthv42LV6vtEfvN5aeKwWyplpzAZGZmG1lLz7IFxlLVqI2RPm/Qs7m6HnpF5tYB7ElhJ87yjA1UpqH783yaCzipcQRl3MnNXsL99wB0TmFCLLNl4OpDIBDgpq2kq6sc= X-MS-Office365-Filtering-Correlation-Id: 804e5d32-2996-453a-09d0-08d36d1e4ce5 X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1928;2:4tr9d4AsbXSCZ9i8pFKUwvkmqkOL5Y90dnRcHJZ2vqlkes4vEIBA5Uhy+HLIf+sv0UybZsMXL7TRDtaNnmi3IthLNU55ECTuwMVJW5QthjTmf0Iio+hgS508IIovMvq+sE49EyV0t74e13GisvrI4+oLq5X05w5QdV72XonY8PA3SeHuCgWCCP8aowV+fIB0;3:/BAdeWYAwNPR6cB4plxe81ONsAZtxkyQTytugNJK0V1dBcLLKAAJOtnZwgRAmBh19VE+vRRzCW2o+vtQepn6+MhUvBfZJjmztN7wNybMIbtAtHmMhOgZx1130a7mHPRwMr78PwDJZv84IGc4hLKgLiDORN5al3xFskeMJCQr0KCvMeVkV8YAexZmcHxhVM2mdIWrNJxYGGQTzKCYhG5j888OsDBo2GAI07jjVlpdW8KyEdVOK2tpUy/oqCgPgbW5m/ypBC+4euzboeCNRGcOpA==;25:xQPb/kXkkK55aT5UqFyrPBPku+mlax464gXIqNhTUwe9yiB9y+zXIk6/J/WjKL67MgeLnMH75J6Gw5eDJDgYBTzSFnwca4WfyCsxCpQjmPvKD7ty9g/NvTrrreZ5S9L5X+zFsGLmPpbGh7kFjN2FQb8OwXgdI2FGjLEB+xrJAvVhtwEpe974D00EhyFIi6ZZwbuKDHx0pZegZGM1kFjuC6T/E9MMdxICxQkvryzxQbu2paCAU8acQ+RQAFSoNzqZ9TF+MAwgv6lCVIdlW0SUxtpzyPojtVHbV/EM3hgCASlc6d0ocCGh9pCMmhurieYdEWnII+wlOB2AYElr1yfKFA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BY2PR0201MB1928; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1928;20:x0GPe/dsCNKvbEWB1OoT4pNcD0oTaE8TyVL7moXyeMq0XGoQ5pU5NUQh0aLXJDqvRe+i25BW13p9kZcsqczOrV/g4f9wCm74+wpaATtPtiscy7L1qeKnYvyS3EfS9XkwYaX8ffKbf1Y/Z1oSt19tIkYsxfhQ5psGzSAL4LmiL4/7Q1NKlIfglDfeKnXfZjHukHJbWwOkW/DvtQYz5MMiV3QaOOi2WzleUCB9uW57+05AEJhbE97B3AkZEST8u4mqrn9X2olV69VctJqhC575HKQJkjVzqXspxrUHjpHkkhFUmXSzxtz8fV+R2ZVJGQgFJsnUDtzvmeTCs7ZpbDsl3a/2OHlbRL+Rv90K97O9IirDgsh4zutgUp2nQSp9wCLVLHxCj3AmYIadv2nE7NvmM8NFFVpng4bxLj/8dN9OebVn9Xzkl+pQ3am9J1pO+Ibdz/z/jQcqPRQAvV0rnZ3euH+B/6wyyuj5ALueWV/lHRGD7kuENNV4XjUVPKaKMCfl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521062)(601004)(2401047)(13016025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BY2PR0201MB1928;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB1928; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1928;4:3oCaXgQTXbd+3rlrTkhn6HNw/XXr9F8mtbYv1heZCCYgOZzhRxq8ey3tHTVCBSyIgbTh3JiMjYWk3CGHErAQkqZSfy+C9RGCxKAOszb42A/K0RmRPuBALKBBIFUHG2hDIcG6FKbC4YP+BzOiStd7iWnvBjFaN+xMzDPsWCI+8RELLm+Yl6AHS38l2N/4qyclE5EoX0s7Bv1mb4zFLoWkR3kCVKZZlln+aWMvfXjTT7mHIh5U6ovthml49uVpFbf6NHeSfjmxRYZ0BCa8ApM98VrnKNse/rmyDC5Wc0vtZJuBsPdas0m+c8lTbH6t/0pRCMIfCV8S0c+KPhQRanT1RoILqpYMBOK5QbTbEoWkRHAZZ1U+PeJgXIJuluLT2VG2uRyJBxUEk3HnZkfWi+AN2eSl/Y5xSF4+VorEbMTs32oH+MoxTcZQA8PCm9My465cj/c4nhzUfMixfzkkXnRLOg== X-Forefront-PRVS: 0923977CCA X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAyMDFNQjE5Mjg7MjM6eXc2M0gxaTlFUTZ5MlFlMHpmQ2N2Wk92?= =?utf-8?B?L0dNYU5DV1dLaGhldExlM2xDZWRVVC9mcnJpMDVvOWkrSVd5NCtzcjN0V2Vz?= =?utf-8?B?SWo4RHpsZEUyUktuaGFLTzJzQmFXN3VnZ044MlpsZDlrZjRUSmx5S1haOXJS?= =?utf-8?B?ZExZcVhKYzFQc3NhYzQzekE3Q3hnME56U21ySzY1dVpCMnFBTXNkK0p3Umpw?= =?utf-8?B?eW5NeXlHd1Uyd0Z1ZXFBcXJtZ2NGUzhCTXlmUmEzMlk1UzhNb2VXSG1pQi9p?= =?utf-8?B?U3ltK0hCbENVQVZ6WGtyK3FXOFYzWit2RlFhTitmSkJVOHJIcElMUkxKMWo1?= =?utf-8?B?Ry9pVjJyOWljN3JYS3RKcjJYL2NBQWVlT0xBU1hmMEdleXNac3pGREF4c3RV?= =?utf-8?B?MUZtdVNUS0xBQnlIMzhaU1BkbmJLSGdaN3pQSDdjbG91MWFzdEs1YUVuMjRv?= =?utf-8?B?MXYyZExZZUhxYlJwSnFZdUx0c0tPV1hvemJrc1kvVUJPSUl3K0llWHlUTlhF?= =?utf-8?B?NkVDSFNNLzd5RkFMY2JORW9xRkhXVE9KYWR2N3B3WktjSC9TM2dWcWM3dlov?= =?utf-8?B?R1R1UU5hdWVnUXpXZ0dSSU5EbS92cDRObnBUMkhFY3JIemhXWGdwZ3FicWVW?= =?utf-8?B?ajNHVmdIYkErbUR2cVZ5bFRvOFVuMEZpS1hLQWpnanhjbVh4VVBDY25sTTdU?= =?utf-8?B?RHZQazNYSFlMUExDUS9MQy90RGsvS0NtdVZyNDFTWHdDNFdHZkVveWlDRXVq?= =?utf-8?B?aGVhVzVWMHdjZ3JDM1F0NXdYZW9PT0lISVRzNVFYb2NsNU1YcGJLNE83ZDFJ?= =?utf-8?B?VVRNYUhOZDVTcGF1ZkRZUmNnbml4eG1tejdPNGpNWVJjakZMc2ZkY2dQbXMw?= =?utf-8?B?bWJSOVpLY1U3eS8rMVIvSHJjeGFCSTFqOVRJcHIxV0JNZ05IWWZ4dExFYlBW?= =?utf-8?B?YWpLOVAxcXByR3ZSZUl3LzZobVFpNnA1dmYwT0hmMUczTjF2MlFiQW5QNWF4?= =?utf-8?B?S3I1a3VucVNrNVcvZ2ozRmNJV1E1N1plYUttREVzWXdocFF5Tmc0UzVabzg2?= =?utf-8?B?ZXB6ZkVQZEhxMXJ1UHNsWWF2Qk04bFZwL1JUYm9HM3I1QVZiT2pyMGhBNjVE?= =?utf-8?B?M0RiWmN4NUlLYjlnT0d2UUNJNXowV29qNW5CaDR2NUZ5YThPdjBhWTZhT3BQ?= =?utf-8?B?ZU9RMHpHWWQ0QTlLVmticWgvSU4vblZGTXhtVXVlUTU2Y3kxMWc1a2VGSC9Q?= =?utf-8?B?TjdOYTZJUE9VWmowREp4ZTlSOVVSWWFPRUdSakZHWU1acUFXamRTazhwR3VD?= =?utf-8?B?bG0xRWIrSDBBcDhRd1hsVzRtOVNJNENtUGloNjVUVTFkdEFpOWFnSFR6cUJZ?= =?utf-8?B?T3hBRkM0L2c0S0dxYnpPYVJHWm1McWY3TVFtWnJqTVRZVUNyaDNmcVNqMDZX?= =?utf-8?B?blk3TG85b2w5dGtJaCtUSkwzVHZxSnJGSThjd0RGQ0hmWXVlNlpaVWFNOFRl?= =?utf-8?Q?8DOH4YLN/CFCPcoqu/8eqzI2tzo=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB1928;5:BtCapcrIzQeeMzhK8mAx0a5NVEy+dhDSK178OcGeF+dILFgBY4knEdGMfVFHTx08o9SazAEA6gWLpAtBAXkAe6piixfgRBZd4WlsT491ee44fa/UDTwaypHuYbNp/QFsLBo0tuiMIkwU6bFSPD4AnoJDppl1fZB6oMCY7jtjwvkBF+uRQBgh+Ye2p7YWYtmj;24:GQNjRKNXvm8G3dsmScyqQSBmSIu3RdbC6jSIGfBy1KOXh4c1a0RYHlyNTunnN3v3xf/MR2nvxaHJ4PuOlK/XXSnkTy4up13kfod/htxMh2g=;7:lUr+Q/hcIsbaMN2BBNDhYiIXBx0jE4XhxIyc3j7v0bVXWIFiorr0PS/Dsjyw+mk/fvZ2H7PZC+rUv4w4CDnuSH2STYsM938J5x+fBwBDZi+ZSk9N7zGxdQzbyfaUfL1xEiXoYvjdddCglJ43Npa7lm0KUZU18bs7XQHdZ3Yg/sFM9BDcBH3Ovlx9nBh/uSv6smFubjOfckuNhG3ORXRql6/maPIe37bbCg2RAOKX2Zc=;20:Bnn2nUPZ+fmTTXLO7rq6HBzZHCcAgzw8SkV6j8ZvgKq31W+xGdOUcbtJgcs0h7XgjBO46Q00vxAx8ggzPN0SYI7eySs+MDFFPgU4/Nsq9LfxnR1QsD1tplHqrLOOWV4bULrUm91LlJrGKf+bUuNENncGqgioieubFOCi2zvWrxPNgVCj44UTqd4ZaFBerEwGwSikYu6XZkumHz3OsGlXi1kVPJq9kSWeggG+KgVzUEKBSwhpzP0QA3XfTDdHxL5x SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2016 15:28:49.1373 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1928 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 417 Lines: 11 On 04/25/2016 05:10 AM, Philipp Reisner wrote: > If during resync we read only zeroes for a range of sectors assume > that these secotors can be discarded on the sync target node. Hello Phil, With which interconnect(s) has this patch been tested? I'm afraid that for high-speed interconnects this patch will slow down I/O instead of making it faster because all_zero() examines all data before it is sent. Bart.