Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933155AbcDYQ1j (ORCPT ); Mon, 25 Apr 2016 12:27:39 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33255 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933054AbcDYQ1h convert rfc822-to-8bit (ORCPT ); Mon, 25 Apr 2016 12:27:37 -0400 MIME-Version: 1.0 In-Reply-To: <571DBFAE.7060605@samsung.com> References: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1459801326-5541-2-git-send-email-ezequiel@vanguardiasur.com.ar> <20160424092551.GB23015@amd> <20160424092951.GA25596@amd> <571DBFAE.7060605@samsung.com> Date: Mon, 25 Apr 2016 13:27:36 -0300 Message-ID: Subject: Re: [PATCH 1/5] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic From: Ezequiel Garcia To: Jacek Anaszewski Cc: Pavel Machek , Linux LED Subsystem , "linux-kernel@vger.kernel.org" , linux-arm-kernel , Richard Purdie Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 40 On 25 April 2016 at 03:56, Jacek Anaszewski wrote: > On 04/24/2016 11:29 AM, Pavel Machek wrote: >> >> On Sun 2016-04-24 11:25:51, Pavel Machek wrote: >>> >>> On Mon 2016-04-04 17:22:02, Ezequiel Garcia wrote: >>>> >>>> This commit adds a new led_cdev flag LED_BLINK_AT_PANIC, which >>>> allows to mark a specific LED to be switched to the "panic" >>>> trigger, on a kernel panic. >>>> >>>> This is useful to allow the user to assign a regular trigger >>>> to a given LED, and still blink that LED on a kernel panic. >>>> >>>> Signed-off-by: Ezequiel Garcia >>> >>> >>> >>>> drivers/leds/led-triggers.c | 52 >>>> +++++++++++++++++++++++++++++++++++++++++++++ >>>> include/linux/leds.h | 1 + >>> >>> >>> Could we get this out of the core? I'm pretty sure most users are not >>> interested... > > > Good point. > Not sure how we can get it out of the core, and still implement it. The goal is to run-time switch user-specified LEDs and blink them when the kernel panics, and so it needs to mess up with some core private structures. Unless we don't want this feature at all. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar