Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933196AbcDYQy1 (ORCPT ); Mon, 25 Apr 2016 12:54:27 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41784 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933013AbcDYQyZ (ORCPT ); Mon, 25 Apr 2016 12:54:25 -0400 Date: Mon, 25 Apr 2016 17:54:17 +0100 From: Mark Brown To: Jon Hunter Cc: Liam Girdwood , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Thierry Reding Message-ID: <20160425165417.GN3217@sirena.org.uk> References: <1461255121-5245-1-git-send-email-jonathanh@nvidia.com> <1461255121-5245-5-git-send-email-jonathanh@nvidia.com> <20160422104837.GC3217@sirena.org.uk> <571A0A81.4010009@nvidia.com> <20160422135339.GD3217@sirena.org.uk> <571E2D48.10509@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m2KU9Mr9JJKQaAoQ" Content-Disposition: inline In-Reply-To: <571E2D48.10509@nvidia.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 35 --m2KU9Mr9JJKQaAoQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 25, 2016 at 03:44:24PM +0100, Jon Hunter wrote: > On 22/04/16 14:53, Mark Brown wrote: > > We need to only *fail* in the bypass case. > OK. So this is what I have now. Is it weird to return EPROBE_DEFER in=20 > _regulator_get_voltage()? If so, I could add a test for bypass in the > regulator_register(). It should be fine but perhaps print an error saying that it's a bypassed regulator with no supply? Deferring for no explicit reason can be confusing. --m2KU9Mr9JJKQaAoQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXHku3AAoJECTWi3JdVIfQ8K4H/RFQrsicyadr+L9Kihf6NBNY aVfrqLPwrEnTYU0yhZSJjQ+zjJKxWBVyKJIk4AcdULvsxy4hpEHuAf+bOJpE3zBX 2p/CcGAlfghSvoDpDogFmDJRevn1xZkwpwvKj0UhGC1cYAw0+9qbDDKxjSsAKmbu gHA8BpgwvjSfl+mAISN1ijdnTAjtl0fdzGjIIZWmmfAYWg07NyPB9iVjXiWsyh2G 1l+xTyvKd/NHgn4bssjfkd+uqaLPVR95U3ymUccyidndgtcxSb1kF61lGu2Q4IFb CWM/xPR3hSJ+lq48InNzqpBT+UTRPsD1UreNdforQO2be4hlHGcqRHIoNC5SQLA= =7VJn -----END PGP SIGNATURE----- --m2KU9Mr9JJKQaAoQ--