Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933240AbcDYRyA (ORCPT ); Mon, 25 Apr 2016 13:54:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52451 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933219AbcDYRx7 (ORCPT ); Mon, 25 Apr 2016 13:53:59 -0400 Date: Mon, 25 Apr 2016 10:53:52 -0700 From: Greg KH To: Jarkko Sakkinen Cc: Andy Lutomirski , Borislav Petkov , Boris Ostrovsky , "open list:STAGING SUBSYSTEM" , Ingo Molnar , Kristen Carlson Accardi , "open list:DOCUMENTATION" , open list , Mathias Krause , Thomas Gleixner , Wan Zongshun Subject: Re: [PATCH 0/6] Intel Secure Guard Extensions Message-ID: <20160425175352.GA16786@kroah.com> References: <1461605698-12385-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461605698-12385-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 37 On Mon, Apr 25, 2016 at 08:34:07PM +0300, Jarkko Sakkinen wrote: > Intel(R) SGX is a set of CPU instructions that can be used by > applications to set aside private regions of code and data. The code > outside the enclave is disallowed to access the memory inside the > enclave by the CPU access control. > > The firmware uses PRMRR registers to reserve an area of physical memory > called Enclave Page Cache (EPC). There is a hardware unit in the > processor called Memory Encryption Engine. The MEE encrypts and decrypts > the EPC pages as they enter and leave the processor package. > > Jarkko Sakkinen (5): > x86, sgx: common macros and definitions > intel_sgx: driver for Intel Secure Guard eXtensions > intel_sgx: ptrace() support for the driver > intel_sgx: driver documentation > intel_sgx: TODO file for the staging area > > Kai Huang (1): > x86: add SGX definition to cpufeature > > Documentation/x86/intel_sgx.txt | 86 +++ > arch/x86/include/asm/cpufeature.h | 1 + > arch/x86/include/asm/sgx.h | 253 +++++++ Why are you asking for this to go into staging? What is keeping it out of the "real" part of the kernel tree? And staging code is self-contained, putting files in arch/* isn't ok for it, which kind of implies that you should get this merged correctly. I need a lot more information here before I can take this code... thanks, greg k-h