Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933333AbcDYSLY (ORCPT ); Mon, 25 Apr 2016 14:11:24 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:52262 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932905AbcDYSLX (ORCPT ); Mon, 25 Apr 2016 14:11:23 -0400 From: Eric Engestrom To: CC: Eric Engestrom , Andrew Morton , Joe Perches , Hannes Frederic Sowa , Rasmus Villemoes , "David S. Miller" , Daniel Borkmann , Andrey Ryabinin Subject: [RFC] Add missing #include Date: Mon, 25 Apr 2016 19:10:55 +0100 Message-ID: <1461607856-27790-1-git-send-email-eric.engestrom@imgtec.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 34 ARRAY_SIZE uses BUILD_BUG_ON_ZERO, which is undefined is you don't include linux/bug.h first, which just happened to me. Is there any reason this include isn't here? A quick grep found 595 other files using a define from bug.h without ever including it. If this is a simple mistake and was forgotten, I can send an actual patchset to fix this, but it feels like it was left out on purpose. Cheers, Eric Engestrom PS: If this is a cleanup that needs to be done, I might to it for other headers as well. --- include/linux/compiler-gcc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index eeae401..01e6869 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -2,6 +2,8 @@ #error "Please don't include directly, include instead." #endif +#include + /* * Common definitions for all gcc versions go here. */ -- 2.8.1