Date: Mon, 25 Apr 2016 14:40:56 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Uwe =?UTF-8?B?S2xlaW5lLUs=?= =?UTF-8?B?w7ZuaWc=?= 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] printk: Add kernel parameter to disable writes to
 /dev/kmsg
Message-ID: <20160425144056.288eea62@gandalf.local.home>
In-Reply-To: <20160425183249.GK28454@pd.tnic>
References: <20160425130629.188a901c@gandalf.local.home>
	<20160425130853.3656910b@gandalf.local.home>
	<20160425183249.GK28454@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 30

On Mon, 25 Apr 2016 20:32:50 +0200
Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Apr 25, 2016 at 01:08:53PM -0400, Steven Rostedt wrote:
> > [ Sorry for the resend, I forgot to add "[PATCH]" to the subject, which
> >   may make this fail filters. ]
> > 
> > Over the weekend my server was acting funny. The display wasn't working
> > well, and I assumed that a driver was going bad. I went to look at the
> > kernel dmesg, but the buffer only had the following over and over:  
> 
> ...
> 
> > +	disable_devkmsg_write
> > +			Disable writing to /dev/kmsg. This prevents user space
> > +			tools from writing into the kernel printk buffers.
> > +			When set, opening /dev/kmsg for write mode will return
> > +			-EPERM.  
> 
> I like the general idea.
> 
> Perhaps can call that param "printk.disable_devkmsg" or so with the
> proper namespace and in light of printk.always_kmsg_dump=...
> 

I agree. And Uwe Kleine-König suggested to make it read_mostly.

I'll send a v2.

-- Steve