Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933381AbcDYSnI (ORCPT ); Mon, 25 Apr 2016 14:43:08 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:42641 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932487AbcDYSnG (ORCPT ); Mon, 25 Apr 2016 14:43:06 -0400 Subject: Re: [PATCH 2/5] iio: inv_mpu6050: Remove inv_mpu6050_hw.num_reg To: Crestez Dan Leonard , linux-iio@vger.kernel.org References: <56c9b2b1-1af7-0b51-372c-94ddba0916c6@kernel.org> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta From: Jonathan Cameron Message-ID: <46714723-7792-191a-43a0-174e8375324a@kernel.org> Date: Mon, 25 Apr 2016 19:43:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <56c9b2b1-1af7-0b51-372c-94ddba0916c6@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2157 Lines: 65 On 24/04/16 12:12, Jonathan Cameron wrote: > On 20/04/16 14:15, Crestez Dan Leonard wrote: >> This field was unused and incorrect for mpu6500. >> >> Signed-off-by: Crestez Dan Leonard . > This one I think I can safely take :) > > Good spot Applied. Thanks, >> --- >> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 --- >> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 2 -- >> 2 files changed, 5 deletions(-) >> >> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c >> index 52e62b3..faccabafc 100644 >> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c >> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c >> @@ -91,19 +91,16 @@ static const struct inv_mpu6050_chip_config chip_config_6050 = { >> /* Indexed by enum inv_devices */ >> static const struct inv_mpu6050_hw hw_info[] = { >> { >> - .num_reg = 117, >> .name = "MPU6050", >> .reg = ®_set_6050, >> .config = &chip_config_6050, >> }, >> { >> - .num_reg = 117, >> .name = "MPU6500", >> .reg = ®_set_6500, >> .config = &chip_config_6050, >> }, >> { >> - .num_reg = 117, >> .name = "MPU6000", >> .reg = ®_set_6050, >> .config = &chip_config_6050, >> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h >> index e302a49..c66dbfc 100644 >> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h >> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h >> @@ -93,13 +93,11 @@ struct inv_mpu6050_chip_config { >> >> /** >> * struct inv_mpu6050_hw - Other important hardware information. >> - * @num_reg: Number of registers on device. >> * @name: name of the chip. >> * @reg: register map of the chip. >> * @config: configuration of the chip. >> */ >> struct inv_mpu6050_hw { >> - u8 num_reg; >> u8 *name; >> const struct inv_mpu6050_reg_map *reg; >> const struct inv_mpu6050_chip_config *config; >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >