Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933313AbcDYStp (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 14:49:45 -0400
Received: from mail-io0-f170.google.com ([209.85.223.170]:36742 "EHLO
	mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932528AbcDYStm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 14:49:42 -0400
Subject: Re: [PATCH v4] ARM64: ACPI: Update documentation for latest
 specification version
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
References: <1461007942-20969-1-git-send-email-al.stone@linaro.org>
 <20160419111545.GB9571@red-moon>
Cc: linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org,
        patches@linaro.org, linaro-kernel@lists.linaro.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Jonathan Corbet <corbet@lwn.net>
From: Al Stone <al.stone@linaro.org>
Message-ID: <571E66C2.3000007@linaro.org>
Date: Mon, 25 Apr 2016 12:49:38 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <20160419111545.GB9571@red-moon>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2087
Lines: 51

On 04/19/2016 05:15 AM, Lorenzo Pieralisi wrote:
> On Mon, Apr 18, 2016 at 01:32:22PM -0600, Al Stone wrote:
>> The ACPI 6.1 specification was recently released at the end of January
>> 2016, but the arm64 kernel documentation for the use of ACPI was written
>> for the 5.1 version of the spec.  There were significant additions to the
>> spec that had not yet been mentioned -- for example, the 6.0 mechanisms
>> added to make it easier to define processors and low power idle states,
>> as well as the 6.1 addition allowing regular interrupts (not just from
>> GPIO) be used to signal ACPI general purpose events.
>>
>> This patch reflects going back through and examining the specs in detail
>> and updating content appropriately.  Whilst there, a few odds and ends of
>> typos were caught as well.  This brings the documentation up to date with
>> ACPI 6.1 for arm64.
>>
[snip...]

>> @@ -185,9 +185,22 @@ tables (all section numbers refer to the ACPI 5.1 specfication):
>>      -- If PCI is supported, the MCFG (Memory mapped ConFiGuration
>>         Table), section 5.2.6, specifically Table 5-31.
>>  
>> +    -- If booting without a console=<device> kernel parameter is
>> +       supported, the SPCR (Serial Port Console Redirection table),
>> +       section 5.2.6, specifically Table 5-31.
>> +
>> +    -- If virtualization is supported, the IORT (Input Output Remapping
>> +       Table, section 5.2.6, specifically Table 5-31.
> 
> Why only "If virtualization is supported" ? Missing closing bracket.

Hrm.  I guess that is an unnecessary qualification.

> I still question sections of this document that IMHO do not belong
> in the kernel documentation (but in the ACPI specs - eg _PRx methods
> usage), anyway the information seems accurate so, pending changes above:
> 
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> 

Thanks, Lorenzo.  The suggested changes all seem fine; I'll include them
in a v5.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------