Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933271AbcDYTHF (ORCPT ); Mon, 25 Apr 2016 15:07:05 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48464 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933121AbcDYTHD (ORCPT ); Mon, 25 Apr 2016 15:07:03 -0400 Date: Mon, 25 Apr 2016 21:06:51 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: Linus Torvalds , LKML , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Andrew Morton , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Message-ID: <20160425190651.GL3448@twins.programming.kicks-ass.net> References: <20160425145606.598329f2@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160425145606.598329f2@gandalf.local.home> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 391 Lines: 11 On Mon, Apr 25, 2016 at 02:56:06PM -0400, Steven Rostedt wrote: > +static bool __read_mostly devkmsg_disabled; > +static int __init disable_devkmsg(char *str) > +{ > + devkmsg_disabled = true; > + return 0; > +} > +__setup("printk.disable_kmsg_write", disable_devkmsg); Again, please default enable and use an easier name to toggle this. Userspace flooding this with junk is really insane.