Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933368AbcDYTNf (ORCPT ); Mon, 25 Apr 2016 15:13:35 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:33530 "EHLO e19.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754766AbcDYTNd (ORCPT ); Mon, 25 Apr 2016 15:13:33 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: stefanb@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core To: Jarkko Sakkinen References: <1461000376-2888-1-git-send-email-stefanb@linux.vnet.ibm.com> <1461000376-2888-2-git-send-email-stefanb@linux.vnet.ibm.com> <20160422150645.GA21128@intel.com> Cc: tpmdd-devel@lists.sourceforge.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org From: Stefan Berger Message-ID: <571E6C56.4080305@linux.vnet.ibm.com> Date: Mon, 25 Apr 2016 15:13:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160422150645.GA21128@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042519-0057-0000-0000-000004241E4C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 36 On 04/22/2016 11:06 AM, Jarkko Sakkinen wrote: > On Mon, Apr 18, 2016 at 01:26:13PM -0400, Stefan Berger wrote: >> From: Jason Gunthorpe >> >> The final thing preventing this was the way the sysfs files were >> attached to the pdev. Follow the approach developed for ppi and move >> the sysfs files to the chip->dev with symlinks from the pdev >> for compatibility. Everything in the core now sanely uses container_of >> to get the chip. >> >> Signed-off-by: Jason Gunthorpe >> Signed-off-by: Stefan Berger > Tested-by: Jarkko Sakkinen > > Three configurations: > > * Haswell NUC with PTT (tpm_crb) > * Another NUC with dTPM 2.0 chip > * Dell E6420, which has TPM 1.2 chip > > Things seem to be unbroken. > > Stefan, have you verified that sysfs attributes work through routes: > > 1. From char device sysfs directory > 2. Through link Tested-by: Stefan Berger > > An also tried insmod/rmmod couple of rounds? Works as-is in polling mode but requires Jason's patch "tpm: Fix IRQ unwind ordering in TIS" for interrupt mode to not throw errors on 'rmmod'. Tested-by: Stefan Berger