Date: Mon, 25 Apr 2016 21:24:35 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to
 /dev/kmsg
Message-ID: <20160425192435.GM3430@twins.programming.kicks-ass.net>
References: <20160425145606.598329f2@gandalf.local.home>
 <20160425190651.GL3448@twins.programming.kicks-ass.net>
 <20160425191815.GA24761@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160425191815.GA24761@kroah.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 900
Lines: 22

On Mon, Apr 25, 2016 at 12:18:15PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 25, 2016 at 09:06:51PM +0200, Peter Zijlstra wrote:
> > On Mon, Apr 25, 2016 at 02:56:06PM -0400, Steven Rostedt wrote:
> > > +static bool __read_mostly devkmsg_disabled;
> > > +static int __init disable_devkmsg(char *str)
> > > +{
> > > +	devkmsg_disabled = true;
> > > +	return 0;
> > > +}
> > > +__setup("printk.disable_kmsg_write", disable_devkmsg);
> > 
> > Again, please default enable and use an easier name to toggle this.
> > Userspace flooding this with junk is really insane.
> 
> If you default enable, you break working systems today that want to log
> stuff through this interface, sorry.

Oh, you mean those 'working' systems that livelocked my box because I
had console to serial enabled which could not keep up with the endless
flood of shite?

This systemd exposure has seriously eroded your sanity.