Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964794AbcDYTbg (ORCPT ); Mon, 25 Apr 2016 15:31:36 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:33616 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933424AbcDYTbf (ORCPT ); Mon, 25 Apr 2016 15:31:35 -0400 Subject: Re: [patch] skd: disable broken discard support To: Jeff Moyer , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: Cc: Thomas Swann , Ramprasad Chinthekindi , Akhil Bhansali From: Jens Axboe Message-ID: <571E7091.7040900@kernel.dk> Date: Mon, 25 Apr 2016 13:31:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 637 Lines: 14 On 04/25/2016 01:19 PM, Jeff Moyer wrote: > Simply creating a file system on an skd device, followed by mount and > fstrim will result in errors in the logs, and even a BUG(). Let's > disable it. As far as I can tell, it hasn't worked right since it was > merged. Note that I've only disabled the reporting here, I haven't > removed the implementation bits in the code. Jens, let me know if you > want me to yank it out completely. I agree with yanking it, but let's remove all the support bits as well so we don't have dead code around. If someone wants to resurrect it, it's all there in the git history anyway. -- Jens Axboe