Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933462AbcDYTdN (ORCPT ); Mon, 25 Apr 2016 15:33:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46117 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933381AbcDYTdM (ORCPT ); Mon, 25 Apr 2016 15:33:12 -0400 From: Jeff Moyer To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Thomas Swann , Ramprasad Chinthekindi , Akhil Bhansali Subject: Re: [patch] skd: disable broken discard support References: <571E7091.7040900@kernel.dk> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 25 Apr 2016 15:33:10 -0400 In-Reply-To: <571E7091.7040900@kernel.dk> (Jens Axboe's message of "Mon, 25 Apr 2016 13:31:29 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 18 Jens Axboe writes: > On 04/25/2016 01:19 PM, Jeff Moyer wrote: >> Simply creating a file system on an skd device, followed by mount and >> fstrim will result in errors in the logs, and even a BUG(). Let's >> disable it. As far as I can tell, it hasn't worked right since it was >> merged. Note that I've only disabled the reporting here, I haven't >> removed the implementation bits in the code. Jens, let me know if you >> want me to yank it out completely. > > I agree with yanking it, but let's remove all the support bits as well > so we don't have dead code around. If someone wants to resurrect it, > it's all there in the git history anyway. Sounds good. Thanks, Jeff