Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933491AbcDYTe0 (ORCPT ); Mon, 25 Apr 2016 15:34:26 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:34430 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933381AbcDYTeY (ORCPT ); Mon, 25 Apr 2016 15:34:24 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160425145606.598329f2@gandalf.local.home> <20160425190651.GL3448@twins.programming.kicks-ass.net> Date: Mon, 25 Apr 2016 12:34:23 -0700 X-Google-Sender-Auth: pbuSPmpxyzkxJrPfA-txCVT5Cn8 Message-ID: Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg From: Linus Torvalds To: Peter Zijlstra Cc: Steven Rostedt , LKML , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Andrew Morton , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 615 Lines: 18 On Mon, Apr 25, 2016 at 12:28 PM, Linus Torvalds wrote: > > I think it should be a tristate with "yes/no/ratelimit", and let's > default to ratelimit. Oh, and in general we should *not* use "negative" settings. It's really annoying to have to enable things with a double negative. So even if you want to disable something, you should see it as an "enable" that is on by default, and you can then disable things by turning that setting off. That just makes things way more logical. (Which is not to say that we haven't made this mistake in the past, but ...) Linus