Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964844AbcDYTs5 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 15:48:57 -0400
Received: from mga03.intel.com ([134.134.136.65]:54387 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S964819AbcDYTs4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 15:48:56 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,534,1455004800"; 
   d="scan'208";a="966240086"
From: Andi Kleen <andi@firstfloor.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Kai Huang <kai.huang@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "maintainer\:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" <x86@kernel.org>,
        Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Huang Rui <ray.huang@amd.com>, Mathias Krause <minipli@googlemail.com>,
        Wan Zongshun <Vincent.Wan@amd.com>,
        "open list\:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" 
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] x86: add SGX definition to cpufeature
References: <1461605698-12385-1-git-send-email-jarkko.sakkinen@linux.intel.com>
	<1461605698-12385-2-git-send-email-jarkko.sakkinen@linux.intel.com>
	<CALCETrXPCzhPWrun4hzgzX4MoB+j50-62yaJsdTAKvyeG+-XqA@mail.gmail.com>
Date: Mon, 25 Apr 2016 12:48:54 -0700
In-Reply-To: <CALCETrXPCzhPWrun4hzgzX4MoB+j50-62yaJsdTAKvyeG+-XqA@mail.gmail.com>
	(Andy Lutomirski's message of "Mon, 25 Apr 2016 12:31:52 -0700")
Message-ID: <87a8kh5v15.fsf@tassilo.jf.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 507
Lines: 16

Andy Lutomirski <luto@amacapital.net> writes:

> On Mon, Apr 25, 2016 at 10:34 AM, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
>> From: Kai Huang <kai.huang@linux.intel.com>
>
> Should this come with a nosgx boot option and an IA32_FEATURE_CONTROL
> check to disable the feature if BIOS doesn't support it?

You can already disable every CPUID feature at boot with clearcpuid=...
No point in adding redundant options for everything.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only