Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964972AbcDYUsL (ORCPT ); Mon, 25 Apr 2016 16:48:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56490 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964783AbcDYUsJ (ORCPT ); Mon, 25 Apr 2016 16:48:09 -0400 Date: Mon, 25 Apr 2016 13:48:06 -0700 From: Stephen Boyd To: Frank Rowand Cc: Andy Gross , David Brown , Greg Kroah-Hartman , Jiri Slaby , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, Linux Kernel list , ivan.ivanov@linaro.org Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message Message-ID: <20160425204806.GG13149@codeaurora.org> References: <571BAC8B.80001@gmail.com> <571BAE11.3020706@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571BAE11.3020706@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 30 On 04/23, Frank Rowand wrote: > From: Frank Rowand > > Failure to enable DMA by the msm_serial driver is silent. > Add a message to report the failure. > > Signed-off-by: Frank Rowand > --- > drivers/tty/serial/msm_serial.c | 1 + > 1 file changed, 1 insertion(+) > > Index: b/drivers/tty/serial/msm_serial.c > =================================================================== > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -170,6 +170,7 @@ rel_tx: > dma_release_channel(dma->chan); > no_tx: > memset(dma, 0, sizeof(*dma)); > + dev_info(dev, "msm_serial: DMA not enabled\n"); > } > Wouldn't this print twice for TX and RX channels? I'd prefer we not print anything when this driver probes, just because it's a bunch of log spam that we don't really need. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project