Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965195AbcDYVbe (ORCPT ); Mon, 25 Apr 2016 17:31:34 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35431 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964869AbcDYVba (ORCPT ); Mon, 25 Apr 2016 17:31:30 -0400 Message-ID: <571E8CAF.4060601@gmail.com> Date: Mon, 25 Apr 2016 14:31:27 -0700 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Stephen Boyd CC: Andy Gross , David Brown , Greg Kroah-Hartman , Jiri Slaby , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, Linux Kernel list , ivan.ivanov@linaro.org Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message References: <571BAC8B.80001@gmail.com> <571BAE11.3020706@gmail.com> <20160425204806.GG13149@codeaurora.org> In-Reply-To: <20160425204806.GG13149@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 43 On 4/25/2016 1:48 PM, Stephen Boyd wrote: > On 04/23, Frank Rowand wrote: >> From: Frank Rowand >> >> Failure to enable DMA by the msm_serial driver is silent. >> Add a message to report the failure. >> >> Signed-off-by: Frank Rowand >> --- >> drivers/tty/serial/msm_serial.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Index: b/drivers/tty/serial/msm_serial.c >> =================================================================== >> --- a/drivers/tty/serial/msm_serial.c >> +++ b/drivers/tty/serial/msm_serial.c >> @@ -170,6 +170,7 @@ rel_tx: >> dma_release_channel(dma->chan); >> no_tx: >> memset(dma, 0, sizeof(*dma)); >> + dev_info(dev, "msm_serial: DMA not enabled\n"); >> } >> > > Wouldn't this print twice for TX and RX channels? I'd prefer we > not print anything when this driver probes, just because it's a > bunch of log spam that we don't really need. This is in msm_request_tx_dma(). I should have made the message "msm_serial: TX DMA not enabled\n" and added a similar message to msm_request_rx_dma(). Then it could print twice, once for TX and once for RX. :-) For my board it would print twice because both requests would fail for the same reason. Should I add it to msm_request_rx_dma() also, but make both locations dev_debug() instead of dev_info()? -Frank