Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965262AbcDYVsj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 17:48:39 -0400
Received: from mail-lf0-f67.google.com ([209.85.215.67]:36362 "EHLO
	mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965170AbcDYVsh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 17:48:37 -0400
MIME-Version: 1.0
In-Reply-To: <20160425214533.GA29990@codeaurora.org>
References: <cover.1461228504.git.viresh.kumar@linaro.org>
	<e42f0fdd6b67461a631ca9d966a52357bbc6cc75.1461228504.git.viresh.kumar@linaro.org>
	<20160422222736.GU13149@codeaurora.org>
	<20160425093650.GG32183@vireshk-i7>
	<20160425214533.GA29990@codeaurora.org>
Date: Mon, 25 Apr 2016 23:48:35 +0200
X-Google-Sender-Auth: QkA-aMavzl8J6yrJUWJourFpysc
Message-ID: <CAJZ5v0htz=F29BAkkGR3XPa1F15o0qg_pUbcPkqbY-COD8UDsQ@mail.gmail.com>
Subject: Re: [PATCH 07/10] cpufreq: dt: Identify cpu-sharing for platforms
 without operating-points-v2
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>, Rafael Wysocki <rjw@rjwysocki.net>,
        Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Nishanth Menon <nm@ti.com>, Arnd Bergmann <arnd.bergmann@linaro.org>,
        andrew@lunn.ch, gregory.clement@free-electrons.com,
        Jason Cooper <jason@lakedaemon.net>, sebastian.hesselbarth@gmail.com,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1007
Lines: 23

On Mon, Apr 25, 2016 at 11:45 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 04/25, Viresh Kumar wrote:
>> On 22-04-16, 15:27, Stephen Boyd wrote:
>> > On 04/21, Viresh Kumar wrote:
>> > > @@ -167,14 +167,16 @@ static int cpufreq_init(struct cpufreq_policy *policy)
>> > >   /* Get OPP-sharing information from "operating-points-v2" bindings */
>> > >   ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, policy->cpus);
> [..]
>> > > +         if (dev_pm_opp_get_sharing_cpus(cpu_dev, policy->cpus))
>> > > +                 fallback = true;
>> >
>> > I'm sort of lost, we make the same call twice here. Why would the
>> > return value change between the first time and the second?
>>
>> Two different APIs, which look similar :)
>>
>> The first one tries to find the sharing-cpus relation from DT, the
>> other one is for v1 bindings and finds it due to platform code
>> dev_pm_opp_set_sharing_cpus() call.
>
> Ah thanks. My eyes glossed over the "of" part. Sounds fine.

So that would be an "ACK", right?