Subject: Re: [PATCH] irq_poll: Remove redundant barrier when using
 clear_bit_unlock()
To: Davidlohr Bueso <dave@stgolabs.net>
References: <1460829336-6146-1-git-send-email-dave@stgolabs.net>
 <5716238D.6040308@sandisk.com> <20160420042340.GD3472@linux-uzut.site>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Davidlohr Bueso" <dbueso@suse.de>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "mingo@kernel.org" <mingo@kernel.org>
From: Bart Van Assche <bart.vanassche@sandisk.com>
Message-ID: <571E98B9.40900@sandisk.com>
Date: Mon, 25 Apr 2016 15:22:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20160420042340.GD3472@linux-uzut.site>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2016 22:22:50.9532
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1928
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 777
Lines: 21

On 04/19/2016 09:23 PM, Davidlohr Bueso wrote:
> On Tue, 19 Apr 2016, Bart Van Assche wrote:
>
>> On 04/16/2016 01:55 PM, Davidlohr Bueso wrote:
>>> ... as the call obviously already implies unlock/RC semantics,
>>> therefore lets get rid of the superfluous smp_mb calls.
>>
>> Hello Davidlohr,
>>
>> Are you sure that this patch has been sent to the right person? I have
>> helped to review a change in this code but I'm not the maintainer of
>> this code.
>
> Ah, adding Andrew and Ingo, not sure who is responsible for these bits.

Please also CC Jens Axboe and Christoph Hellwig. Jens is the original 
author of this code. See also "block: add blk-iopoll, a NAPI like 
approach for block devices" 
(https://groups.google.com/forum/#!topic/linux.kernel/aMhcMrYaXC8).

Bart.