Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbcDYX07 (ORCPT ); Mon, 25 Apr 2016 19:26:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:48649 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbcDYX05 (ORCPT ); Mon, 25 Apr 2016 19:26:57 -0400 Date: Mon, 25 Apr 2016 20:26:52 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: kan.liang@intel.com, namhyung@kernel.org, jolsa@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 1/1] perf hists: clear dummy entry accumulated period Message-ID: <20160425232652.GA15298@kernel.org> References: <1461565689-5862-1-git-send-email-kan.liang@intel.com> <20160425181500.GA16635@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160425181500.GA16635@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 47 Em Mon, Apr 25, 2016 at 08:15:00PM +0200, Jiri Olsa escreveu: > On Sun, Apr 24, 2016 at 11:28:09PM -0700, kan.liang@intel.com wrote: > > From: Kan Liang > > > > The accumulated period for dummy entry should also be 0. > > Otherwise, the total overhead could be overcounted. > > [perf]$ perf record -e '{LLC-load-misses,cpu/instructions/}' > > --call-graph=lbr ./tchain > > [perf]$ perf report --stdio > > # To display the perf.data header info, please use > > --header/--header-only options. > > # > > # > > # Total Lost Samples: 0 > > # > > # Samples: 21K of event 'anon group { LLC-load-misses, > > cpu/instructions/ > > }' > > # Event count (approx.): 16313667937 > > # > > # Children Self Command Shared Object > > Symbol > > # ................ ................ ........... ................ > > ............................ > > # > > 4769.98% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux] > > [k] update_fast_timekeeper > > 4356.18% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux] > > [k] trigger_load_balance > > 3181.12% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux] > > [k] irq_work_tick > > 1592.37% 0.00% 0.00% 0.00% tchain_edit [kernel.vmlinux] > > [k] cpu_needs_another_gp > > > > Signed-off-by: Kan Liang > > --- > > > > Changes since V2: > > - Use symbol_conf.cumulate_callchain check for existance of he->stat_acc > > Changes since V1: > > - check he->stat_acc. Because it only be available when option children is set > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo