Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbcDZAot (ORCPT ); Mon, 25 Apr 2016 20:44:49 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36307 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbcDZAop (ORCPT ); Mon, 25 Apr 2016 20:44:45 -0400 Message-ID: <571EB9FB.9070402@gmail.com> Date: Mon, 25 Apr 2016 17:44:43 -0700 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Stephen Boyd CC: Andy Gross , David Brown , Greg Kroah-Hartman , Jiri Slaby , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, Linux Kernel list , ivan.ivanov@linaro.org Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message References: <571BAC8B.80001@gmail.com> <571BAE11.3020706@gmail.com> <20160425204806.GG13149@codeaurora.org> <571E8CAF.4060601@gmail.com> <20160425213527.GH13149@codeaurora.org> In-Reply-To: <20160425213527.GH13149@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 30 On 4/25/2016 2:35 PM, Stephen Boyd wrote: > On 04/25, Frank Rowand wrote: >> >> This is in msm_request_tx_dma(). I should have made the message >> "msm_serial: TX DMA not enabled\n" and added a similar message >> to msm_request_rx_dma(). >> >> Then it could print twice, once for TX and once for RX. :-) >> For my board it would print twice because both requests would >> fail for the same reason. > > Ah right, the 3 line diff window caught me here. > >> >> Should I add it to msm_request_rx_dma() also, but make both >> locations dev_debug() instead of dev_info()? > > Honestly I don't see much point in having this at all. Why does > the user care if DMA is used or not? Don't they just want the > hardware to work? Maybe dev_dbg(), but again, debug junk. I'll > leave it up to you and Greg. If the user doesn't care if DMA is used then why even bother implementing it in the driver? :-) I don't _need_ the messages, I just need the driver to quit dropping bytes and writing corrupt bytes. So patch 1 of 2 is sufficient for my needs. -Frank