Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751848AbcDZA5u (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 20:57:50 -0400
Received: from mail-pa0-f43.google.com ([209.85.220.43]:33756 "EHLO
	mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751060AbcDZA5s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 20:57:48 -0400
Date: Tue, 26 Apr 2016 09:59:19 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Yu Zhao <yuzhao@google.com>
Cc: Dan Streetman <ddstreet@ieee.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Seth Jennings <sjenning@redhat.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
        Linux-MM <linux-mm@kvack.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Dan Streetman <dan.streetman@canonical.com>
Subject: Re: [PATCH] mm/zpool: use workqueue for zpool_destroy
Message-ID: <20160426005919.GA9699@swordfish>
References: <CALZtONCDqBjL9TFmUEwuHaNU3n55k0VwbYWqW-9dODuNWyzkLQ@mail.gmail.com>
 <1461619210-10057-1-git-send-email-ddstreet@ieee.org>
 <20160425221816.GA1254@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160425221816.GA1254@google.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1240
Lines: 28

On (04/25/16 15:18), Yu Zhao wrote:
> On Mon, Apr 25, 2016 at 05:20:10PM -0400, Dan Streetman wrote:
> > Add a work_struct to struct zpool, and change zpool_destroy_pool to
> > defer calling the pool implementation destroy.
> > 
> > The zsmalloc pool destroy function, which is one of the zpool
> > implementations, may sleep during destruction of the pool.  However
> > zswap, which uses zpool, may call zpool_destroy_pool from atomic
> > context.  So we need to defer the call to the zpool implementation
> > to destroy the pool.
> > 
> > This is essentially the same as Yu Zhao's proposed patch to zsmalloc,
> > but moved to zpool.
> 
> Thanks, Dan. Sergey also mentioned another call path that triggers the
> same problem (BUG: scheduling while atomic):
>   rcu_process_callbacks()
>           __zswap_pool_release()
>                   zswap_pool_destroy()
>                           zswap_cpu_comp_destroy()
>                                   cpu_notifier_register_begin()
>                                           mutex_lock(&cpu_add_remove_lock);
> So I was thinking zswap_pool_destroy() might be done in workqueue in zswap.c.
> This way we fix both call paths.

right, I'm not sure the patch addressed all of the issues.

	-ss