Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbcDZBYk (ORCPT ); Mon, 25 Apr 2016 21:24:40 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:34082 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbcDZBYi (ORCPT ); Mon, 25 Apr 2016 21:24:38 -0400 From: Vivien Didelot To: Colin King , "David S . Miller" , Andrew Lunn , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix uninitialized error return In-Reply-To: <1461622282-30463-1-git-send-email-colin.king@canonical.com> References: <1461622282-30463-1-git-send-email-colin.king@canonical.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Mon, 25 Apr 2016 21:24:34 -0400 Message-ID: <87wpnlmab1.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 23 Hi Colin, Colin King writes: > From: Colin Ian King > > The error return err is not initialized and there is a possibility > that err is not assigned causing mv88e6xxx_port_bridge_join to > return a garbage error return status. Fix this by initializing err > to 0. > > Signed-off-by: Colin Ian King Reviewed-by: Vivien Didelot Even though that cannot happen, the fix doesn't hurt. Adding Geert in the loop who submitted an RFC for this first: https://lkml.org/lkml/2016/4/25/95 Thanks, Vivien