Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbcDZBy7 (ORCPT ); Mon, 25 Apr 2016 21:54:59 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33591 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbcDZBy5 (ORCPT ); Mon, 25 Apr 2016 21:54:57 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [patch] skd: remove broken discard support From: Jens Axboe X-Mailer: iPhone Mail (13F61) In-Reply-To: Date: Mon, 25 Apr 2016 19:54:54 -0600 Cc: Akhil.Bhansali@hgst.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: To: Jeff Moyer Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 639 Lines: 18 > On Apr 25, 2016, at 4:06 PM, Jeff Moyer wrote: > > Simply creating a file system on an skd device, followed by mount and > fstrim will result in errors in the logs and then a BUG(). Let's remove > discard support from that driver. As far as I can tell, it hasn't > worked right since it was merged. This patch also has a side-effect of > cleaning up an unintentional shadowed declaration inside of > skd_end_request. > > I tested to ensure that I can still do I/O to the device using xfstests > ./check -g quick. I didn't do anything more extensive than that, > though. Applied, thanks Jeff. -- Jens Axboe