Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbcDZEje (ORCPT ); Tue, 26 Apr 2016 00:39:34 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:35962 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbcDZEjc (ORCPT ); Tue, 26 Apr 2016 00:39:32 -0400 MIME-Version: 1.0 In-Reply-To: <1460971325-26982-2-git-send-email-simhavcs@gmail.com> References: <1460971325-26982-1-git-send-email-simhavcs@gmail.com> <1460971325-26982-2-git-send-email-simhavcs@gmail.com> Date: Tue, 26 Apr 2016 10:09:31 +0530 Message-ID: Subject: Re: [PATCH 2/2] drm/dsi: Implement DCS get display self diagnostic From: Vinay Simha To: Vinay Simha BN Cc: David Airlie , "open list:DRM DRIVERS" , open list , Thierry Reding Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2496 Lines: 72 HI, I have not got response from maintainers. Did i miss anything? On Mon, Apr 18, 2016 at 2:52 PM, Vinay Simha BN wrote: > Provide a small convenience wrapper that transmits > a DCS get_diagnostic_result command. > > Signed-off-by: Vinay Simha BN > --- > drivers/gpu/drm/drm_mipi_dsi.c | 25 +++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 2e032ea..e49b346 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -816,6 +816,31 @@ int mipi_dsi_dcs_get_display_mode(struct mipi_dsi_device *dsi, u8 *mode) > EXPORT_SYMBOL(mipi_dsi_dcs_get_display_mode); > > /** > + * mipi_dsi_dcs_get_diagnostic_result() - query the display module's diagnostic > + * result > + * @dsi: DSI peripheral device > + * @mode: return location for the display self diagnostic result > + * > + * Return: 0 on success or a negative error code on failure. > + */ > +int mipi_dsi_dcs_get_diagnostic_result(struct mipi_dsi_device *dsi, u8 *mode) > +{ > + ssize_t err; > + > + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DIAGNOSTIC_RESULT, mode, > + sizeof(*mode)); > + if (err <= 0) { > + if (err == 0) > + err = -ENODATA; > + > + return err; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_dcs_get_diagnostic_result); > + > +/** > * mipi_dsi_dcs_get_pixel_format() - gets the pixel format for the RGB image > * data used by the interface > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 48fcd65..61c375b 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -255,6 +255,7 @@ int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_soft_reset(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_get_power_mode(struct mipi_dsi_device *dsi, u8 *mode); > int mipi_dsi_dcs_get_display_mode(struct mipi_dsi_device *dsi, u8 *mode); > +int mipi_dsi_dcs_get_diagnostic_result(struct mipi_dsi_device *dsi, u8 *mode); > int mipi_dsi_dcs_get_pixel_format(struct mipi_dsi_device *dsi, u8 *format); > int mipi_dsi_dcs_enter_sleep_mode(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_exit_sleep_mode(struct mipi_dsi_device *dsi); > -- > 2.1.2 > -- Regards, Vinay Simha.B.N.